Repository navigation
Build the macOS assets on macos-26 - #13
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The runner migration is consistent, preserves ARM64 architecture, and leaves compatibility safeguards intact.
0 open findings
What changed in this PR
Updates macOS release asset builds to use the supported macOS 15 ARM64 runner.
Changes:
- Switches the release job from
macos-14tomacos-15. - Updates comments explaining runner selection and architecture.
| File | Description |
|---|---|
.github/workflows/release.yml |
Moves macOS ARM64 asset builds to macOS 15. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
horgh
force-pushed
the
wstorey/macos-15
branch
from
October 7, 2026 21:06
059e31f to
c2581a1
Compare
setup-php installs PHP from shivammathur/php tap bottles. The tap has bottles only for the macOS versions that Homebrew supports, and macOS 14 is not one of them. On macos-14, setup-php 2.37.2 builds PHP and its dependencies from source. Its inactivity watchdog kills and retries the build until no php binary exists, and the step fails with "Could not setup PHP". See shivammathur/setup-php#1125. macos-26 is the newest pinned arm64 image. Homebrew and GitHub support it for longer than macos-15. The version stays pinned rather than macos-latest so that the build image changes only with a commit. The runner does not set the macOS floor of the assets. The build step pins MACOSX_DEPLOYMENT_TARGET to 11.0, and the gate step fails if the measured minos is higher. The assets support macOS 11 and later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
horgh
force-pushed
the
wstorey/macos-15
branch
from
October 7, 2026 21:15
c2581a1 to
260acd7
Compare
horgh
changed the title
oschwald
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS jobs fail on
macos-14in the "Install PHP" step. For example, see run 37322667367 on #12.mainfails the same way on its next run.Cause
Homebrew dropped support for macOS 14 on 2026-09-10 (Homebrew/brew
85ceb6ae). Theshivammathur/phptap stopped building macOS 14 bottles, and since 2026-09-23 the PHP 8.2 and 8.5 formulas have noarm64_sonomabottle. setup-php 2.37.2 then builds PHP from source. Its 180-second inactivity watchdog kills the build and retries it, and the step fails after 30 to 45 minutes with "Could not setup PHP". The upstream issue is shivammathur/setup-php#1125.GitHub also retires the
macos-14image on 2026-11-02 (actions/runner-images#13518).Change
macos-26. All PHP formulas the release matrix uses (8.2 to 8.5, nts and zts) havearm64_tahoebottles.macos-latest, so that the build image changes only with a commit.macos-14.Effect on the assets
None. The runner does not set the macOS floor. The build step pins
MACOSX_DEPLOYMENT_TARGETto11.0, and the gate step fails if the measuredminosis higher. libmaxminddb is bundled, so the object links no Homebrew libraries.A test build on
macos-15produced binaries that match the v1.14.0 assets (built onmacos-14) in everything except the SDK version field:minos11.0,libSystemonly, the same imported symbols, and no weak imports. This PR's CI onmacos-26gives the same comparison for the new SDK.The one loss: the load-and-query test now runs on macOS 26 instead of 14.
Alternative not taken
setup-php 2.40.0-beta installs a prebuilt PHP that supports
macos-14. It is a prerelease, and upstream marksmacos-14as deprecated, so this PR does not use it.🤖 Generated with Claude Code