Repository navigation
Conversation
setup-php 2.37.2 installs PHP on macOS from the live Homebrew tap. It resets Homebrew to origin/main and hides the brew output. Homebrew changes from 2026-10-07 to 2026-10-09 broke this path. The macos-26 release job uses it. setup-php 2.40.0 resolves tap formula aliases before it calls brew and uses the Homebrew API when homebrew-core is not tapped. It also installs prebuilt PHP builds on macOS. Dependabot's 7-day cooldown would delay this update until 2026-10-19. ENG-5610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The pinned SHA correctly corresponds to setup-php 2.40.0 and the change is narrowly scoped.
0 open findings
What changed in this PR
Updates the macOS release workflow to restore PHP installation compatibility.
Changes:
- Pins
setup-php2.40.0 using its verified commit SHA.
| File | Description |
|---|---|
.github/workflows/release.yml |
Updates setup-php for macOS release builds. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
oschwald
approved these changes
Oct 11, 2026
oschwald
deleted the
wstorey/eng-5610-geoip2-php-fix-macos-ci-by-updating-setup-php-to-2400
branch
October 11, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
macosjob inrelease.ymlinstalls PHP onmacos-26with setup-php 2.37.2. The same setup fails now in GeoIP2-php, minfraud-api-php and web-service-common-php CI. This workflow runs on pull requests, so this PR tests the macOS release legs with 2.40.0.Cause
setup-php 2.37.2 installs PHP on macOS from the live
shivammathur/phpHomebrew tap. It resets Homebrew toorigin/main, setsHOMEBREW_NO_INSTALL_FROM_API=1, and hides the brew output. Homebrew changes from 2026-10-07 to 2026-10-09 broke this path. setup-php 2.40.0 fixes it:php@8.5, before it calls brew.shivammathur/php-darwin.The same update for GeoIP2-php is maxmind/GeoIP2-php#351.
Change
Pin
shivammathur/setup-phpto 2.40.0 inrelease.yml. Dependabot's 7-day cooldown would delay this update until 2026-10-19.ENG-5610
🤖 Generated with Claude Code