Repository navigation
Conversation
Use the same setup-php version as the other MaxMind PHP repositories. 2.37.2 breaks on macOS because Homebrew changed from 2026-10-07 to 2026-10-09. This repository has no macOS jobs, so its CI is not affected now. ENG-5610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The change only updates the PHP setup action pins across the listed workflows; no actionable merge-blocking risk is established. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: updating setup-php to version 2.40.0 across the workflows. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the workflow lines
The PHP pin now advances
Five paths follow the new commit
Two bundled steps join the change
The test runs hop along their way
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
All setup-php references consistently use the verified commit for version 2.40.0.
0 open findings
What changed in this PR
Updates all CI workflows to pin shivammathur/setup-php 2.40.0 at its verified commit SHA.
Changes:
- Updates all six
setup-phpusages from 2.37.2 to 2.40.0. - Keeps workflow configurations otherwise unchanged.
| File | Description |
|---|---|
.github/workflows/test.yml |
Updates test PHP setup. |
.github/workflows/test-bundled.yml |
Updates both bundled-build jobs. |
.github/workflows/lint.yml |
Updates lint PHP setup. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL PHP setup. |
.github/workflows/clang-analyzer.yml |
Updates analyzer PHP setup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pin
shivammathur/setup-phpto 2.40.0 in all workflows, to match the other MaxMind PHP repositories.This repository has no macOS jobs, so its CI does not fail now. setup-php 2.37.2 fails on macOS because of Homebrew changes from 2026-10-07 to 2026-10-09. See maxmind/GeoIP2-php#351 for the cause.
ENG-5610
🤖 Generated with Claude Code
Summary by CodeRabbit