Repository navigation
Conversation
setup-php 2.37.2 installs PHP on macOS from the live Homebrew tap. It resets Homebrew to origin/main and hides the brew output. Homebrew changes from 2026-10-07 to 2026-10-09 broke this path, and the PHP 8.5 macOS job fails with "Could not setup PHP 8.5". setup-php 2.40.0 resolves tap formula aliases before it calls brew and uses the Homebrew API when homebrew-core is not tapped. It also installs prebuilt PHP builds on macOS. Dependabot's 7-day cooldown would delay this update until 2026-10-19. ENG-5610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The change updates the PHP setup action in both workflows, with no identified merge-blocking concern. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: updating setup-php to version 2.40.0 to address macOS CI failures. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the workflow pins,
And finds new PHP setup begins.
Two files now point to version two-forty,
The lint and tests proceed quite neatly.
I hop away beneath the moon,
With updated pins in tune.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
The verified 2.40.0 pin is correct and consistently replaces all existing setup-php references.
0 open findings
What changed in this PR
Updates the PHP setup action to restore macOS CI compatibility.
Changes:
- Pins
setup-php2.40.0 by its verified commit SHA. - Applies the update consistently to test and lint workflows.
| File | Description |
|---|---|
.github/workflows/test.yml |
Updates PHP setup across the test matrix. |
.github/workflows/lint.yml |
Updates PHP setup for lint checks. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The scheduled PHPUnit workflow fails on
macos-latestin the "Setup PHP" step (run 38111622074). The PHP 8.5 job fails withCould not setup PHP 8.5, and the other macOS jobs are cancelled.Cause
setup-php 2.37.2 installs PHP on macOS from the live
shivammathur/phpHomebrew tap. It resets Homebrew toorigin/main, setsHOMEBREW_NO_INSTALL_FROM_API=1, and hides the brew output. Homebrew changes from 2026-10-07 to 2026-10-09 broke this path. setup-php 2.40.0 fixes it:php@8.5, before it calls brew.shivammathur/php-darwin.The same update for GeoIP2-php is maxmind/GeoIP2-php#351.
Change
Pin
shivammathur/setup-phpto 2.40.0 intest.ymlandlint.yml. Dependabot's 7-day cooldown would delay this update until 2026-10-19.ENG-5610
🤖 Generated with Claude Code
Summary by CodeRabbit