Skip to content

fix(events): implement DispatchableFromNative and require nativephp/mobile ^3.3.11|^4.6.1 - #1

Merged
nunomazer merged 1 commit into
mainfrom
fix/dispatchable-from-native
Oct 28, 2026
Merged

nunomazer merged 1 commit into
mainfrom
fix/dispatchable-from-native

Conversation

@nunomazer

Copy link
Copy Markdown
Contributor

Summary

NativePHP Mobile 3.3.11 and 4.6.1 (GHSA-83jv-8h7x-287p) make /_native/api/events refuse event classes that do not implement Native\Mobile\Events\Contracts\DispatchableFromNative. Without the marker, Laravel listeners for Dialogify events stop receiving them on patched versions.

  • ButtonPressed, ToastAction and InputSubmitted implement DispatchableFromNative.
  • Requires nativephp/mobile ^3.3.11|^4.6.1; the interface does not exist in earlier versions.
  • README documents that custom event classes passed to ->event() must implement the marker.
  • CHANGELOG entry for 1.0.1.

Tests

  • New test: events can be dispatched from native (all three events).
  • Suite: 65 passed against nativephp/mobile 4.6.1 and 3.3.11.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nunomazer
nunomazer merged commit c748e79 into main Oct 28, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant