Repository navigation
fix(deps): require zod ^4.6.6 in core and mcp for GHSA-mrhx-c7xc-m3w5 - #330
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped dependency requirements, lockfile changes, and release notes are consistent, with no blocking defects identified.
No open issues 🎉
What changed in this PR
Completes #329’s dependency hardening by raising the Zod minimum for future published installs, rather than relying only on the repository lockfile.
Changes:
- Raises core, MCP, and root workspace requirements to
zod ^4.6.6, with matching lockfile specifications. - Updates the documentation site’s resolved Zod to 4.6.7.
- Adds an Unreleased security note explaining the consumer-facing protection.
Decision compliance was not independently verified because the adrkit MCP server was unavailable.
| File | Description |
|---|---|
site/bun.lock |
Updates Zod to 4.6.7 and its integrity hash. |
packages/mcp/package.json |
Raises MCP’s Zod minimum to 4.6.6. |
packages/core/package.json |
Raises core’s Zod minimum to 4.6.6. |
package.json |
Aligns the root development dependency minimum. |
CHANGELOG.md |
Documents the security fix under Unreleased. |
bun.lock |
Aligns all three workspace dependency specifications. |
Review effort: Balanced
Decisions governing this change8 accepted decisions govern this change
Links point at |
@adrkit/mcp still declare ^4.6.5. A consumer whose tree already holds 4.6.5 keeps it. Raising the floor to ^4.6.6 excludes the only affected release in range from every install of the next lockstep release. The root workspace declaration and bun.lock's three workspace specs move with it; the resolved zod is unchanged at 4.6.7, so packages/ci/dist and schema/adr.schema.json do not change, and check:clean-clone passes. The documentation site has its own lockfile and resolved zod 4.6.5 through Astro. I moved that single entry to 4.6.7 and kept Astro's range untouched; the site builds (72 pages). build, typecheck, lint, audit:gate, check:changelog, check:clean-clone, and the full suite (4544 pass, 2 skip) pass. Signed-off-by: Mark Beacom <m@beacom.dev>
mbeacom
force-pushed
the
fix/zod-floor-4-6-6
branch
from
October 25, 2026 16:28
282974e to
d8bf15f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
#329 moved this repository's lockfile to zod 4.6.7, which turned the audit gate green. But
@adrkit/coreand@adrkit/mcpstill declarezod: ^4.6.5. A consumer whose tree already holds 4.6.5 keeps the release affected by GHSA-mrhx-c7xc-m3w5, which says validating oversized constrained collections can exhaust memory. Raising the floor to^4.6.6keeps every install of the next lockstep release off it.packages/core,packages/mcp, the root workspace, andbun.lock's three workspace specs:^4.6.5→^4.6.6. The resolved zod is still 4.6.7.site/bun.lock: the docs site's own lockfile resolved zod 4.6.5 through Astro. I changed only that entry, to 4.6.7, and left Astro's range alone.CHANGELOG.md: a### Securityentry under Unreleased, so this goes out with the next lockstep release.Checklist
^4.6.5as history, so I left it as is.schema/adr.schema.jsonis byte-identical.packages/ci/distdoesn't need regenerating:check:clean-clonepasses with no diff.build,typecheck,lint,audit:gate,check:changelog,check:clean-clone, and the full suite (4544 pass, 2 skip, 0 fail) pass. The site builds 72 pages.Notes for reviewers
The site's
bun auditstill lists two high advisories, both in build-time dependencies: undici 8 through Astro (GHSA-xjj6-f33q-929c) and launch-editor through Vite (GHSA-587h-7wmj-h5pm). Neither ships in any package, and the required audit gate doesn't cover the site. I've left them for a separate site dependency pass rather than widening this one.