Repository navigation
fix(site): refresh the docs site's build dependencies to clear ten advisories - #331
Merged
Merged
Conversation
…visories The docs site has its own lockfile, outside the root audit gate, and `bun audit` there reported ten advisories (two high, seven moderate, one low), all in build-time dependencies: - undici 8.11.2, via Astro's unifont: GHSA-xjj6-f33q-929c (high), GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472. - vite 8.3.2 and the launch-editor code it bundles: GHSA-587h-7wmj-h5pm (high), five moderate, one low. - postcss-selector-parser 6.1.4, via postcss-nested: GHSA-rj75-hqrm-r3gf. I dropped the undici and vite lockfile entries and let bun re-resolve under the site's 3-day minimumReleaseAge. That moved more than those two: every change stays inside its declared range, including astro 7.3.7 -> 7.4.2, starlight 0.42.5 -> 0.42.6, vite 8.3.5, undici 8.12.3, and postcss-nested 7, which brings postcss-selector-parser 7.1.7. No package.json changes. `bun audit` now reports no vulnerabilities. The site builds 72 pages with the same two content warnings main prints, check:schema passes, and check:rendered holds all 40 rendered invariants in Chrome. Signed-off-by: Mark Beacom <m@beacom.dev>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Decisions governing this change5 accepted decisions govern this change
Links point at |
Astro 7.4 requires Node >=22.23.4, and the runner image's default Node is 22.23.3, so the Deploy site build failed on this branch. Set up Node explicitly instead of inheriting the image's patch level; 24 matches the portal Action's runtime. Signed-off-by: Mark Beacom <m@beacom.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The docs site has its own lockfile, outside the root
auditgate.bun auditthere reported ten advisories: two high, seven moderate, one low. All of them are in build-time dependencies, and none ships in any@adrkit/*package:unifont: GHSA-xjj6-f33q-929c (high), plus two moderate.launch-editorcode it bundles: GHSA-587h-7wmj-h5pm (high), plus five moderate and one low.postcss-nested: GHSA-rj75-hqrm-r3gf (moderate). The only fix is in 7.x.I dropped the undici and vite lockfile entries and let bun re-resolve under the site's 3-day
minimumReleaseAge. That moved more than those two packages, but every change stays inside its declared range and nopackage.jsonchanges. Notable moves:Checklist
check:schemapasses.packages/ci/srcand@adrkit/coreare untouched.bun auditreports no vulnerabilities, the site builds 72 pages, andcheck:renderedholds all 40 rendered invariants in Chrome.Notes for reviewers
The build prints the same two content warnings that
mainprints: an emptyi18ncollection and no404docs entry. This change doesn't introduce them.The lockfile diff is wide because of the in-range refresh. If you'd rather review something narrower, the vulnerable packages could be pinned individually instead, but postcss-selector-parser would then need an override to reach 7.x.
The Deploy site build now sets up Node 24 explicitly. Astro 7.4 requires Node >=22.23.4, and the runner image's default Node is 22.23.3, so the first push failed in
astro build. The site builds andcheck:renderedpasses under Node 24 locally.