fix(responses): strip null entries from the dispatched Responses body - #957
Merged
Merged
Conversation
Pass-through dispatch forwards the client body verbatim, so null content parts that the parser now tolerates still reached providers, which rejected them with "input[0].content did not match any supported type". Remove null input items, content parts and summary parts from the body before dispatch.
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). |
Contributor
🔍 OpenCodeReview — detailed findings✅ Passing — no critical/high findings. Reviewed 2 file(s), 0 finding(s) total. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #955. Plexus no longer crashes on Responses requests that contain empty (
null) entries, but it still passed those entries on to providers unchanged, and providers rejected the request. Plexus now removes the empty entries before sending the request on, so these requests succeed.🐛 Bug Fixes
nullentries ininput, messagecontent, or reasoning summaries no longer fail with the provider error "input[0].contentdid not match any supported type". The empty entries are removed before the request is forwarded.