Remove browser-specific claims about console.timeStamp() - #45615
Merged
Merged
Conversation
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs (5 pages)
External URLs (2)URL:
(comment last updated: 2026-09-22 04:53:46) |
wbamberg
reviewed
Sep 21, 2026
wbamberg
left a comment
wbamberg
left a comment
Collaborator
There was a problem hiding this comment.
I like the direction of this but had a couple of additional suggestions.
Co-authored-by: wbamberg <will@bootbonnet.ca>
github-actions
Bot
added
size/m
wbamberg
reviewed
Sep 22, 2026
| - `end` {{Optional_Inline}} {{Experimental_Inline}} | ||
| - : A string referencing a previously defined `timeStamp` label or a timestamp ({{domxref("DOMHighResTimeStamp")}}) to be used as the end time. | ||
|
|
||
| - `label` {{Optional_Inline}} |
Collaborator
There was a problem hiding this comment.
I don't know why we have un-alphabetised the parameters here.
Member
Author
There was a problem hiding this comment.
Because these are positional arguments and their order matters, not an options object?
Collaborator
There was a problem hiding this comment.
Oh fair enough! Sorry my brain stopped working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22588.
According to BCD, FF 149+ supports
console.timeStamp()to the profiler, so this content isn't "wrong" per se, but certainly not future-proof. Replaced with handwavy claims that it's implementation dependent, because there's BCD anyway.