Skip to content

fix: prevent PR review comment menus from being clipped #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mechiland merged 1 commit into from
Nov 2, 2026
Merged

fix: prevent PR review comment menus from being clipped #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/code/diff.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,13 @@
overflow-x: auto;
}

/* A horizontal scroller also clips vertically. Let an open review menu extend below the diff;
horizontal scrolling (including its previous offset) resumes when the dropdown closes. */
.repository .diff-file-box .code-diff-split:has(.comment-code-cloud .ui.dropdown.active) {
overflow-x: clip;
z-index: var(--zIndex-dropdown);
}

.repository .diff-file-box .code-diff-split table {
width: max(100%, 2 * (var(--base-size-64) + var(--base-size-8) + 6 * var(--base-size-48)));
}
Expand Down
16 changes: 13 additions & 3 deletions src/pages/issues-prs/review.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
* and the reply trigger (a default Button here, github.com has no green button in threads).
*/

/* Menus in comment headers must be able to extend past the thread (issue #6).
Round the header/footer backgrounds themselves instead of clipping the whole Box. */
.code-comments-list .conversation-holder {
overflow: hidden;
border: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: var(--borderRadius-medium);
background: var(--bgColor-default);
Expand All @@ -25,10 +26,14 @@
padding-right: var(--base-size-16);
border: 0;
border-bottom: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: 0;
border-radius: var(--borderRadius-medium) var(--borderRadius-medium) 0 0;
background: var(--bgColor-muted);
}

.code-comments-list .conversation-holder > .collapsible-comment-box:has(~ .comment-code-cloud.tw-hidden) {
border-radius: var(--borderRadius-medium);
}

.code-comments-list .conversation-holder .file-comment {
color: var(--fgColor-accent);
font-family: var(--fontStack-monospace);
Expand Down Expand Up @@ -101,6 +106,7 @@
.code-comments-list .conversation-holder > .comment-code-cloud > .flex-text-block {
padding: var(--base-size-8) var(--base-size-16);
border-top: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: 0 0 var(--borderRadius-medium) var(--borderRadius-medium);
background: var(--bgColor-muted);
}

Expand All @@ -125,6 +131,7 @@
.code-comments-list .conversation-holder > .comment-code-cloud > form.comment-form {
padding: 0 var(--base-size-8);
border-top: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: 0 0 var(--borderRadius-medium) var(--borderRadius-medium);
background: var(--bgColor-muted);
}

Expand Down Expand Up @@ -157,12 +164,13 @@
1px --borderColor-muted — then a --bgColor-muted footer with the thread actions. Gitea: every comment is its own
bordered Box with a caret and the avatar outside, the timeline's .comment-list gutter + line around them. */
.repository.view.issue .code-diff .conversation-holder > .comment-code-cloud {
overflow: hidden;
border: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: var(--borderRadius-medium);
}

.repository.view.issue .code-diff .conversation-holder .comment-code-cloud > .comment-list {
/* The timeline line is hidden here; its stacking context would trap menus below later diff files. */
isolation: auto;
margin: 0;
padding: 0;
}
Expand Down Expand Up @@ -228,6 +236,7 @@
.repository.view.issue .code-diff .conversation-holder .comment-code-cloud > .flex-text-block {
padding: var(--base-size-8) var(--base-size-16);
border-top: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: 0 0 var(--borderRadius-medium) var(--borderRadius-medium);
background: var(--bgColor-muted);
}

Expand All @@ -252,6 +261,7 @@
margin: 0;
padding: var(--base-size-8) var(--base-size-16) 0;
border-top: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: 0 0 var(--borderRadius-medium) var(--borderRadius-medium);
background: var(--bgColor-muted);
}

Expand Down