feat(schema)!: adopt Record declarations for beta.3 - #488
Conversation
|
Important Review skippedToo many files! This PR contains 160 files, which is 60 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (160)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ Deploy Preview for prisma-dart canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a37da133d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review exact head a37da13. The private Record field finding was reproduced and is already rejected by the analyzer diagnostic gates before any schema or named SQL output is emitted; details and positive SQL-name mapping evidence are in #488 (comment). Please verify that evidence and reassess the remaining diff. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a37da133d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Review final head 55c5a96 after the fixes for empty CHECK names and computed-only models. Both new regression cases failed before the fixes and now pass with source-located GenerationException diagnostics. The first private Record field finding remains resolved by the existing semantic diagnostic gates, with reproduction evidence in its thread. Please review the final changes and report any remaining actionable findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55c5a96ef7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Replace annotated entities and separately authored row types with a single
model('table', (columns...))declaration. The generator emits immutable rows and typed query APIs; named Record fields declare local keys, checks, and forward/reverse relationships.Modelis a non-constructible type annotation for cyclic references.This is the breaking schema change in 6.0.0-beta.3. The old public declarations, annotation reader, generation branches, and authoring tools are removed. Catalog import, CLI initialization, named SQL, fixtures, and public guides use the new API. Existing physical snapshots and migration history stay unchanged.
Validation
6256e4f136720fda6ea6c948ba9c76e4930aba85; all review threads are resolved.dart pub publish --dry-run: zero warnings.No related open issue.