Skip to content

feat(client): drop the deprecated building block shapes - #36

Open
grubmeshi wants to merge 3 commits into
mainfrom
feature/make-bb-bbd-ga
Open

feat(client): drop the deprecated building block shapes#36
grubmeshi wants to merge 3 commits into
mainfrom
feature/make-bb-bbd-ga

Conversation

@grubmeshi

@grubmeshi grubmeshi commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Removes the deprecated building block shapes from the client. meshcloud/terraform-provider-meshstack#274 uses this branch.

  • Removes the v1 building block client (client.BuildingBlock, MeshBuildingBlock and its DTOs).
  • Removes the deprecated parentBuildingBlocks field. Parents go in parentBuildingBlockRefs alone.
  • Removes status.status and the status list filter. The tfstate lock uses MeshBuildingBlockRun.IsRunning().
  • The clients keep the v2-preview and v1-preview media types. This works against the current meshStack and needs no newer release; MinMeshStackVersion stays 2026.36.0.
  • A follow-up switches to the GA media types and raises the floor once the meshStack GA release (meshcloud/meshfed-release#10612) is out.

🤖 Generated with Claude Code

@grubmeshi grubmeshi mentioned this pull request Oct 14, 2026
Open
@grubmeshi
grubmeshi force-pushed the feature/make-bb-bbd-ga branch from 150da74 to 21849ca Compare October 14, 2026 08:41
@meshcloud-gh-actions

meshcloud-gh-actions Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage of the acceptance run against the meshStack backend, on 09cee566705d1989b39fca29987e6ab6a862be08.

Scope Coverage
Unit tests 78.3%
Acceptance tests 55.2%
Combined 80.9%
Uncovered functions 
client/api_key.go:52: meshApiKeyClient.Create 0.0%
client/api_key.go:56: meshApiKeyClient.Read 0.0%
client/api_key.go:60: meshApiKeyClient.Update 0.0%
client/api_key.go:64: meshApiKeyClient.Delete 0.0%
client/api_key_permissions.go:20: ApiKeyPermissions.AllCodes 0.0%
client/api_key_permissions.go:33: ApiKeyPermissions.WorkspaceCodes 0.0%
client/api_key_permissions.go:262: AllApiKeyPermissions 0.0%
client/api_key_permissions.go:266: WorkspacePermissionCodes 0.0%
client/building_block_definition.go:71: MeshBuildingBlockDefinitionApprovalPolicies.NothingRequiresApproval 0.0%
client/building_block_definition.go:82: DisabledSchedule 0.0%
client/building_block_definition.go:89: MeshBuildingBlockDefinitionSchedule.IsDisabled 0.0%
client/building_block_definition.go:93: MeshBuildingBlockDefinitionSpec.HasNeutralPolicies 0.0%
client/building_block_definition.go:97: MeshBuildingBlockDefinitionSpec.WithNeutralPolicies 0.0%
client/building_block_definition.go:166: meshBuildingBlockDefinitionClient.List 0.0%
client/building_block_definition.go:173: meshBuildingBlockDefinitionClient.Read 0.0%
client/building_block_definition.go:177: meshBuildingBlockDefinitionClient.Create 0.0%
client/building_block_definition.go:181: meshBuildingBlockDefinitionClient.Update 0.0%
client/building_block_definition.go:185: meshBuildingBlockDefinitionClient.Delete 0.0%
client/building_block_definition_version.go:101: MeshBuildingBlockType.TagInputTargets 0.0%
client/building_block_definition_version.go:245: meshBuildingBlockDefinitionVersionClient.Create 0.0%
client/building_block_definition_version.go:254: meshBuildingBlockDefinitionVersionClient.Update 0.0%
client/building_block_definition_version_implementation.go:81: MeshBuildingBlockDefinitionImplementation.InferType 0.0%
client/building_block_definition_version_implementation.go:95: MeshBuildingBlockDefinitionImplementation.MarshalJSONTo 0.0%
client/building_block_definition_version_implementation.go:108: *MeshBuildingBlockDefinitionImplementation.UnmarshalJSONFrom 0.0%
client/building_block_runner.go:93: meshBuildingBlockRunnerClient.Create 0.0%
... and 127 more

covdata func names a method without its receiver, so an entry can belong to an implementation nothing selects rather than to a function the tests never reached. Open the file and line before reading one as a coverage gap.

@grubmeshi
grubmeshi force-pushed the feature/make-bb-bbd-ga branch from 5c2ccf0 to c99b890 Compare October 14, 2026 10:51
@grubmeshi
grubmeshi marked this pull request as ready for review October 14, 2026 10:53
@grubmeshi
grubmeshi requested a review from j0g3sc October 14, 2026 10:54
j0g3sc
j0g3sc approved these changes Oct 19, 2026
View reviewed changes
Comment thread client/types/variant/variant.go Outdated
"fmt"
"reflect"

wirejson "github.com/meshcloud/meshstack-cli/internal/json"

@j0g3sc j0g3sc Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d: why the named import now?

Comment thread internal/json/marshal.go
// wireCompatibility keeps the output in the shape encoding/json v1 wrote, because the meshObject API
// reads a null collection differently from an empty one. Sorted map keys keep the files written here
// stable. A MarshalJSON method gets none of its caller's options, so it marshals through [Marshal].
var wireCompatibility = json.JoinOptions(

@j0g3sc j0g3sc Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: just to double check is this still needed, i've seen only removals in this PR.

@grubmeshi
grubmeshi force-pushed the feature/make-bb-bbd-ga branch 2 times, most recently from 4ccd1dc to 78d9b1d Compare October 26, 2026 07:28
@grubmeshi grubmeshi mentioned this pull request Oct 26, 2026
Merged
@grubmeshi
grubmeshi force-pushed the feature/make-bb-bbd-ga branch 4 times, most recently from 07f2c14 to d2c5dcc Compare October 29, 2026 14:08
@grubmeshi
grubmeshi force-pushed the feature/make-bb-bbd-ga branch 2 times, most recently from 8796b47 to 09cee56 Compare November 4, 2026 19:01
@grubmeshi
grubmeshi requested a review from j0g3sc November 4, 2026 19:37
grubmeshi and others added 3 commits November 4, 2026 22:30
@grubmeshi @claude
feat(client): drop the deprecated building block shapes
54f1569 
The meshBuildingBlock client sends the parents in
spec.parentBuildingBlockRefs alone, which every meshStack from
MinMeshStackVersion on reads, so the client drops the deprecated
parentBuildingBlocks field and its MarshalJSON and UnmarshalJSON. The v1
building block client (client.BuildingBlock, MeshBuildingBlock and its DTOs)
goes as well: only the Terraform provider's removed meshstack_buildingblock
resource used it.

The client no longer reads the deprecated status.status and drops the status
list filter: it drops BuildingBlockStatus, the Status field of
MeshBuildingBlockV2Status and MeshBuildingBlockV2ListFilter.Status. Callers
read status.action. MeshBuildingBlockRun.IsRunning takes over the run status
check of the tfstate lock.

The clients keep the v2-preview and v1-preview media types, so they work
against the current meshStack and against the release that makes these APIs
GA.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@grubmeshi @claude
refactor(client): pass the caller's JSON options through to nested va…
bef669b 
…lues

The custom JSON methods implement json/v2's MarshalJSONTo and
UnmarshalJSONFrom, which receive the options of the encoder or decoder.
The options internal/json marshals every request with now reach a nested
value on their own, so the client and the variant package no longer keep
copies of them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@grubmeshi @claude
chore(lint): forbid encoding/json v1 everywhere
b86a5d1 
One depguard rule over all files denies exactly encoding/json, so the
per-package rules no longer repeat that deny.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@grubmeshi
grubmeshi force-pushed the feature/make-bb-bbd-ga branch from 09cee56 to b86a5d1 Compare November 4, 2026 21:31
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@grubmeshi grubmeshi changed the title feat(client): move building blocks and their definitions to the GA APIs feat(client): drop the deprecated building block shapes Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j0g3sc j0g3sc Awaiting requested review from j0g3sc

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grubmeshi @j0g3sc