Repository navigation
Conversation
MeshBuildingBlockV2Client.Update takes MeshBuildingBlockV2UpdateOptions, sent as query parameters. SkipRun asks meshStack to save the update without starting a run; the zero value sends no parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
Collaborator
Author
|
Closed without merge: BD-2867 is answered with Building Block run approval policies (preflight run, approval only when the plan has changes). An update without a run would leave the block stale until an unrelated later run applies the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



bb-update-await-run
BD-2867: a building block update through the meshObject API can skip its run. meshStack gets an optional
skipRunquery parameter onPUT /api/meshobjects/meshbuildingblocks/{uuid}.MeshBuildingBlockV2Client.UpdatetakesMeshBuildingBlockV2UpdateOptionsand sends it as URL query withhttp.WithUrlQuery.SkipRun: truesendsskipRun=true. The zero value sends no parameter, so it works against a meshStack without the parameter.MeshObjectClient.Putaccepts request options for this.This changes the
Updatesignature. The Terraform provider updates its callers and its mock in its PR.Tests
TestMeshBuildingBlockV2Client_UpdateSendsSkipRunOnlyWhenSetchecks the query string for the zero value and forSkipRun: true.task lintandtask testpass.Cross-repo PRs
skipRunquery parameterskip_run_on_updateonmeshstack_building_block🤖 Generated with Claude Code