Repository navigation
Conversation
With four-eyes approval on, meshStack keeps a binding created through the API pending until a person approves it in meshPanel. Workspace and project bindings now carry "status.approval", ASSIGNED or PENDING, so the Terraform provider can tell its users. Group bindings get a status for this. BD-2877 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With four-eyes approval on, meshStack now sends role bindings made through the meshObject API through approval (meshcloud/meshfed-release#11623). A binding can then be pending. This adds
status.approval(ASSIGNEDorPENDING) to user and group bindings, so the Terraform provider can warn while a binding waits for approval.Older meshStacks do not send the field, so it stays nil.
🤖 Generated with Claude Code