Repository navigation
refactor: share smoke-test run ids through smoke_run.hcl - #28
Merged
Merged
Conversation
Both e2e units built `name_suffix` and `run_id` with the same inline `run_cmd` calls. Move them to `smoke_run.hcl` so the shape is defined once, as in likvid-cloudfoundation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both e2e units built
name_suffixandrun_idwith copies of the samerun_cmdcalls. They now read them fromfoundations/meshstack-trial/smoke_run.hcl, the pattern likvid-cloudfoundation uses (see itshubskill).run_cmdis cached per unit, so each unit in arun --allstill gets its ownrun_id.Smoke test on this branch passed for both units: https://github.com/meshcloud/trial-cloudfoundation/actions/runs/38930266041
🤖 Generated with Claude Code