Repository navigation
feat(map): mesh view pictures, track direction and time fade, barometric height - #7719
Conversation
The viewfinder renders embedded so a window copy holds the camera feed and the overlay together.
… leaves the viewer from the bottom The bottom panel sums the track up and says when the window holds no positions; legs at the viewer draw from the bottom of the view, as route links do.
…mesh view One fade in feature:map, measured across the track's own span and falling back to order when a time is missing, replaces four copies that faded by order.
…, or the whole mesh
`/nodes/{n}/mesh-view`, `/nodes/{n}/position/mesh-view` and `/map/mesh-view`, each over the screens its button lives on.
A dark node color vanished against a dark scene, worst on the faint old end of a track.
… direction of travel As in the Chirpy Hop backdrop: sparks spaced by length on screen, flowing oldest to newest along a track and hop by hop along each traceroute leg. They hold still while the phone is hot.
… follow the ground Sparks were spaced by length on screen, so turning the phone slid them along the path; they now sit by angle along it, fewer and slower. A long track leg is stepped along the ground instead of cutting a chord between its ends.
… a second Frozen sparks only shifted as the view turned, which read as motion tied to the camera.
GPS height now averages like the position, weighted by vertical accuracy. Where the phone has a barometer, pressure carries every change in height and GPS settles the level over a minute.
riseM moves next to its only caller to keep HudGeometry under the function cap, and the track gradient notes why its stops are spread.
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Tests Prove The Path, Not The End State |  |
Several added tests are non-discriminating. HudPathsTest.a short leg stays a straight chord between its ends asserts only groundDirections(a, b).size == 2 (line 228), so arbitrary two directions p… |
Strengthen the short-leg test by asserting both returned directions equal the computed endpoints. In the phase test, assert non-empty output and the expected spark bearings for both phases. In the sea-level test, assert the expected pressur… |
| Regression Coverage For Changed Behavior | |
Regression coverage remains incomplete. The changed production paths have helper tests, but the observable integrations and failure branches remain untested: - PicturesStore.saveJpegToPictures (39-6… |
Add the Android host, sensor, common, map-consumer, drawing/frame-clock, and Compose UI tests above. Keep assertions for every listed failure branch, timestamp fallback, stale-fix branch, platform branch, and Google/MapLibre renderer integr… |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately summarizes the main changes: mesh-view picture capture, track direction and time-based fading, and barometric height support. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Sibling Call Sites And Presence Semantics PASS. The diff does not touch NodeItem or NodeItemCompact, and it does not change ambient-temperature presence semantics. TrackPoint changes ageSec to nullable fixTimeSec without changing nullability;… Moved Code Diffed Against Its Original The only clear code move is saveToPicturesfromArCapture.kttoPicturesStore.kt. Its@RequiresApicontract, MediaStore setup, JPEG quality, title sanitization, pending-row cleanup, exception …Full details: Sibling Call Sites And Presence Semantics
-
Explanation
PASS. The diff does not touch NodeItem or NodeItemCompact, and it does not change ambient-temperature presence semantics. TrackPoint changes ageSec to nullable fixTimeSec without changing nullability; all TrackPoint consumers use fixTimeSec. PhoneLocation altitude and mslAltitude were already nullable. No new RSSI, temperature, current, voltage, particulate-concentration, or app-level nullable SNR field defaults to 0.
Full details: Moved Code Diffed Against Its Original
-
Explanation
The only clear code move is
saveToPicturesfromArCapture.kttoPicturesStore.kt. Its@RequiresApicontract, MediaStore setup, JPEG quality, title sanitization, pending-row cleanup, exception handling, and nullable return behavior are preserved line-for-line.captureArScenestill calls it on the I/O dispatcher, and the new HUD caller also uses the I/O dispatcher. The renamed public utility is an explicit part of the sharedcore:uidesign, not a silent move defect. No old caller remains on the removed declaration, and no listed annotation, validation, nullability, coroutine-policy, or interface change was introduced by the move.
-
Full details: Tests Prove The Path, Not The End State
-
Explanation
Several added tests are non-discriminating.
HudPathsTest.a short leg stays a straight chord between its endsasserts onlygroundDirections(a, b).size == 2(line 228), so arbitrary two directions pass.a phase one spacing on puts every spark back where it wascompares two results but never asserts that either result contains sparks (lines 209-215), so an empty-output implementation passes.AltitudeFuserTest.the sea level height moves with the fused onechecks onlymslAltitude == altitude - 25(line 86); a fuser that ignores the pressure change still satisfies this relation. No changed test asserts emission order underUnconfinedTestDispatcher, and no added test seeds a backing store and only reads the value back.Resolution
Strengthen the short-leg test by asserting both returned directions equal the computed endpoints. In the phase test, assert non-empty output and the expected spark bearings for both phases. In the sea-level test, assert the expected pressure-shifted altitude and MSL altitude (approximately 155 m and 130 m), in addition to their relationship.
Full details: Regression Coverage For Changed Behavior
-
Explanation
Regression coverage remains incomplete. The changed production paths have helper tests, but the observable integrations and failure branches remain untested: -
PicturesStore.saveJpegToPictures(39-62),captureWindow(58-106), andcaptureArScene(41-52) can regress in MediaStore metadata, JPEG compression, publish, cleanup, PixelCopy failure, zero-size windows, API-level gating, context unwrapping, and single-flight capture. No matching Android tests exist. Add host tests with a fakeContentResolverfor success, insert/open/compress/update failures, and pending-row deletion. Add capture tests for API < Q, invalid windows, PixelCopy failure,ContextWrapper, and repeated taps. -AndroidPhonePressureProvider.pressureUpdates(30-49) andMeshHudViewModelpressure integration (234-247) have no sensor or controllable-flow tests. The current ViewModel test only suppliesNoBarometer(86-88). Add Android sensor-fake tests for missing sensors, registration, emitted values, cancellation, and unregister. Add ViewModel tests for pressure updates, fused-height propagation, and suppression of altitude-only changes below 0.25 m. -AltitudeFuser.calibratedhas an explicit stale/out-of-order branch (101-108), butAltitudeFuserTestdoes not exercise it. Add a newer-fix then older-fix test and assert that the offset and fused height remain unchanged.FixAverager.meanHeightuses the new missing-vertical-accuracy fallback (95-105), but the tests cover only known accuracy and missing height. Add two height-bearing fixes with one missingverticalAccuracyMand assert the fallback weighting. - GoogleNodeTrackOverlay(1456-1530) and MapLibrepointFeatures/TrackLineLayer(209-278) now consume timestamp recency.TrackFadeTestandTrackLineStopsTesttest helpers only. Add consumer tests for old, widely separated, newest, missing, zero, and invalid timestamps, including Google marker opacity/z-index and segment gradients and MapLibre point opacity and line-gradient stops. -drawTrack,drawRoute, andMeshHudScreennow render casings, alpha, viewer-origin paths, directional sparks, and normal/hot frame scheduling (HudPathsDraw 119-311; MeshHudScreen 187-199 and 262-280).HudPathsTestcovers path-sampling helpers only. Add recording draw-command tests for direction, casing, per-leg alpha, viewer paths, and route/track sparks. Add a Compose frame-clock test for path open/close and normal versus hot tick cadence. -HudTopBar,HudBottomPanel,TrackLegend, and their screen wiring (HudPanels 138-180, 204-243, 349-377; MeshHudScreen 335-351) have no Compose UI tests. Add tests for the conditional camera button and callback, empty and summarized tracks, accessibility text, and suppression of the no-nodes message while a track is active.Resolution
Add the Android host, sensor, common, map-consumer, drawing/frame-clock, and Compose UI tests above. Keep assertions for every listed failure branch, timestamp fallback, stale-fix branch, platform branch, and Google/MapLibre renderer integration.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
github-actions
Bot
added
desktop
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: meshtastic/Meshtastic-Android/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
d6de7680-9330-41db-af12-cd66b4106a3d
📒 Files selected for processing: 34
.skills/compose-ui/strings-index.txtandroidApp/src/google/kotlin/org/meshtastic/app/map/MapView.ktandroidApp/src/google/kotlin/org/meshtastic/app/node/ArCapture.ktcore/navigation/src/commonMain/kotlin/org/meshtastic/core/navigation/DeepLinkRouter.ktcore/navigation/src/commonTest/kotlin/org/meshtastic/core/navigation/DeepLinkRouterTest.ktcore/resources/src/commonMain/composeResources/values/strings.xmlcore/ui/src/androidMain/kotlin/org/meshtastic/core/ui/util/PicturesStore.ktdesktopApp/src/main/kotlin/org/meshtastic/desktop/di/DesktopStubsModule.ktdesktopApp/src/main/kotlin/org/meshtastic/desktop/stub/CompassStubs.ktfeature/map-maplibre/src/commonMain/kotlin/org/meshtastic/feature/map/maplibre/NodeTrackMap.ktfeature/map-maplibre/src/commonTest/kotlin/org/meshtastic/feature/map/maplibre/TrackLineStopsTest.ktfeature/map/src/androidMain/kotlin/org/meshtastic/feature/map/hud/AndroidPhonePressureProvider.ktfeature/map/src/androidMain/kotlin/org/meshtastic/feature/map/hud/HudCameraPreview.android.ktfeature/map/src/androidMain/kotlin/org/meshtastic/feature/map/hud/HudCapture.android.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/TrackFade.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/AltitudeFuser.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/FixAverager.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudCapture.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudGeometry.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudPanels.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudPathSampling.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudPaths.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudPathsDraw.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/HudRadarPaths.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/MeshHudScreen.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/MeshHudViewModel.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/PhonePressureProvider.ktfeature/map/src/commonTest/kotlin/org/meshtastic/feature/map/TrackFadeTest.ktfeature/map/src/commonTest/kotlin/org/meshtastic/feature/map/hud/AltitudeFuserTest.ktfeature/map/src/commonTest/kotlin/org/meshtastic/feature/map/hud/FixAveragerTest.ktfeature/map/src/commonTest/kotlin/org/meshtastic/feature/map/hud/HudPathsTest.ktfeature/map/src/commonTest/kotlin/org/meshtastic/feature/map/hud/MeshHudViewModelTest.ktfeature/map/src/iosMain/kotlin/org/meshtastic/feature/map/hud/HudCapture.ios.ktfeature/map/src/jvmMain/kotlin/org/meshtastic/feature/map/hud/HudCapture.jvm.kt
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
…ix has none A tap during a save is ignored, a window that loses its surface reports a failed save instead of crashing, and a fix without a GPS height keeps the barometer height on the last level.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: meshtastic/Meshtastic-Android/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
95142259-2f8d-4546-8e71-b815860ae7d4
📒 Files selected for processing: 3
feature/map/src/androidMain/kotlin/org/meshtastic/feature/map/hud/HudCapture.android.ktfeature/map/src/commonMain/kotlin/org/meshtastic/feature/map/hud/AltitudeFuser.ktfeature/map/src/commonTest/kotlin/org/meshtastic/feature/map/hud/AltitudeFuserTest.kt
🚧 Files skipped from review as they are similar to previous changes: 2
- feature/map/src/commonTest/kotlin/org/meshtastic/feature/map/hud/AltitudeFuserTest.kt
- feature/map/src/androidMain/kotlin/org/meshtastic/feature/map/hud/HudCapture.android.kt
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
The mesh view (#7659) shows where a node's track went but not which way, fades it by point order rather than time, and its own height bobs with every GPS fix. This makes tracks and traceroutes read at a glance on the camera, steadies the phone's height with the barometer, and lets the view be saved and opened from a link.
🌟 New Features
12 points over 3h 20m · newest 5 min. ago), also what TalkBack reads, plus an empty-window message and age tags on the oldest fix and one near the middle of a long track./nodes/{n}/mesh-view,/nodes/{n}/position/mesh-viewand/map/mesh-view.🐛 Bug Fixes
🛠️ Refactoring & Architecture
TrackFadeinfeature:mapreplaces four copies of the fade (both maps, the mesh view and its radar).saveJpegToPicturesincore:uiandroidMain is shared by the AR device viewer and the mesh view.PhonePressureProviderwith an Android barometer source and a desktop no-op.Testing Performed
TrackFadeTest,TrackLineStopsTest,AltitudeFuserTest: new.HudPathsTest: summary, label picks, viewer legs, sparks by angle, ground stepping.FixAveragerTest: height averaging.DeepLinkRouterTest: the three mesh view links.Summary by CodeRabbit
New Features
Improvements
Bug Fixes