Repository navigation
feat(map): draw nodes at one spot as one counted chip on both maps #7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
df8d936
feat(map): draw nodes at one spot as one counted chip on both maps
jamesarich 9b60665
fix(map): split and test name digits the same way in the stack list o…
jamesarich 9132a88
test(map): make the digit-order test fail under the old isDigit check
jamesarich d56154b
fix(map): list and sort stacked nodes by their local display names
jamesarich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Supported by static analysis
Script executed:
Repository: meshtastic/Meshtastic-Android
Length of output: 38972
Script executed:
Repository: meshtastic/Meshtastic-Android
Length of output: 42967
Web query:
official GitHub source com.google.maps.android android-maps-utils 6.1.0 NonHierarchicalDistanceBasedAlgorithm max distance clusteringResult:
Web query:
official GitHub source com.google.maps.android maps-compose 9.0.1 Clustering default algorithmResult:
Web query:
site:github.com/googlemaps/android-maps-utils/blob v6.1.0 NonHierarchicalDistanceBasedAlgorithm DEFAULT_MAX_DISTANCE_BETWEEN_CLUSTERED_ITEMS 100Result:
Web query:
github googlemaps android-maps-utils NonHierarchicalDistanceBasedAlgorithm "maxDistanceBetweenClusteredItems" sourceResult:
Script executed:
Repository: meshtastic/Meshtastic-Android
Length of output: 253
Script executed:
Repository: meshtastic/Meshtastic-Android
Length of output: 44003
Ensure a cluster tap can split distinct stack tops.
A cluster containing at least 10 distinct stack tops can remain clustered after the 140 m minimum fit. The distance-based algorithm groups items by a zoom-dependent screen distance, and a 140 m geographic floor does not guarantee that a 6 m separation exceeds that distance. A second tap then recomputes the same bounds because
allSameLocationis false, so the cluster does not open its member list. Fit closer, or open the member list when a cluster remains unchanged after fitting.