Repository navigation
feat(wio_tracker_l1_pro_1w): enable the DFU screen - #89
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure board display src/boards/wio_tracker_l1_pro_1w/board.h, changelog.md |
The board header defines the SH1106 controller, I2C address, bus pins, dimensions, column offset, and title. The changelog adds the board to the DFU-screen list and updates the listed count of boards following firmware-variant pins. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Feature
Possibly related PRs
- meshtastic/Adafruit_nRF52_Bootloader_OTAFIX#66: Adds the L1 Pro 1W board and its base board definition, which this PR extends with display settings.
- meshtastic/Adafruit_nRF52_Bootloader_OTAFIX#70: Implements DFU screen rendering, which this PR enables for the L1 Pro 1W through its display configuration.
Suggested reviewers: rcarteraz
Merge Risk: 
efc0a
-
The configuration is consistent with the supported hardware and remains safe when no display responds.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: enabling the DFU screen for the wio_tracker_l1_pro_1w board. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the screen aglow
One-W marks the path to show
Six and five carry the stream
SH1106 lights the scene
Five boards now join the dream
The rabbit hops past pixels green
And tucks the changelog in between
Comment @coderabbitai help to get the list of available commands.
efc0a9d to
9fb4ccb
Compare
Checklist
tools/build_all.py(or CI's board matrix) passesDescription of Change
The L1 Pro 1W has the same 1.3" SH1106 OLED at 0x3D on P0.06/P0.05 as the L1 (firmware's
configuration.handseeed_wio_tracker_L1_Pro_1Wvariant), so it gets the sameDISPLAY_*block aswio_tracker_l1, titledL1 PRO 1W. A board with no panel answering shows nothing and behaves as before.Builds clean (gcc 13.3, 34952 B text+data). @rcarteraz flashed it on a 1W and the DFU screen comes up.