Skip to content

Make multi-rank runtime analysis independent of artifact order - #183

Open
Arnavsharma2 wants to merge 1 commit into
meta-pytorch:mainfrom
Arnavsharma2:fix/runtime-artifact-order
Open

Arnavsharma2 wants to merge 1 commit into
meta-pytorch:mainfrom
Arnavsharma2:fix/runtime-artifact-order

Conversation

@Arnavsharma2

@Arnavsharma2 Arnavsharma2 commented Sep 13, 2026 •

Copy link
Copy Markdown

Sort each rank's runtime artifacts by graph ID before comparison so filesystem order cannot cause comparisons between different graphs. Adds a regression using stored traces that fails on upstream and passes with the fix.

Validation: 7 tests pass
Suite: 64 passed, one pre-existing failure 'test_all_ranks_chromium_events_combined`

AI helped in the development of this

@meta-cla

meta-cla Bot commented Sep 13, 2026

Copy link
Copy Markdown

Hi @Arnavsharma2!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the cla signed label Sep 13, 2026
@Arnavsharma2
Arnavsharma2 marked this pull request as ready for review September 13, 2026 04:49
Copilot AI lite review requested due to automatic review settings September 13, 2026 04:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants