Make multi-rank runtime analysis independent of artifact order - #183
Arnavsharma2 wants to merge 1 commit into
Conversation
|
Hi @Arnavsharma2! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Sort each rank's runtime artifacts by graph ID before comparison so filesystem order cannot cause comparisons between different graphs. Adds a regression using stored traces that fails on upstream and passes with the fix.
Validation: 7 tests pass
Suite: 64 passed, one pre-existing failure 'test_all_ranks_chromium_events_combined`
AI helped in the development of this