Repository navigation
fix(core): align TreeList guides to chevrons - #8774
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewModified ComponentsTreeList (@astryxdesign/core) · View in Storybook
Component Size
Sizes are gzip. Import counts the JavaScript the import loads eagerly; CSS counts the package stylesheet rules referenced by the modules it can load from its own package, lazily loaded ones included. Bundle Size SummaryGzip figures measure each package's entry file, not the code an import pulls in.
Accessibility AuditStatus: The accessibility audit did not run on this pull request. It runs after merges to Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
There was a problem hiding this comment.
This pull request needs an owner decision before it can be approved. The new component:TreeList DD4 design decision and its verification row are what authorize moving every chevron and guide 4px toward the row's inline start, and neither is approved for this head yet. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so if they are an engineering owner. Separately, the changeset needs to follow spec:AST-017 FR3: use [feat] for this intentional visual change and state the old and new appearance (chevrons and guides 4px closer to the row's start, the chevron-to-label gap widening from 4px to 8px, labels unchanged).
[Automated review]
There was a problem hiding this comment.
This pull request needs an owner decision before it can be approved: the new component:TreeList DD4 design decision and its verification row are what authorize moving every chevron and guide 4px toward the row's inline start, and the engineering-owner approval they received applied to an earlier commit, so it does not cover the current head. An engineering owner records that decision again, or rejects it, by commenting /approve-spec <full head SHA> on this pull request; the author may do so if they are an engineering owner. Nothing else blocks: labels, row geometry, theme targets and RTL mirroring are unchanged, the new browser test passes, and the changeset follows the release rules for an intentional visual change.
[Automated review]
71b4c84 to
e512ed5
Compare
Pull request was closed
There was a problem hiding this comment.
This pull request needs an owner decision before it can be approved: the new component:TreeList DD4 design decision and its verification row are what authorize moving every chevron and guide 4px toward the row's inline start, and the engineering-owner approval they received applied to an earlier commit, so it does not cover the current head after the rebase. An engineering owner records that decision again, or rejects it, by commenting /approve-spec <full head SHA> on this pull request; the author may do so if they are an engineering owner. Nothing else blocks: labels, row geometry, theme targets and RTL mirroring are unchanged, the new browser test passes on this head and catches the old chevron margins, and the changeset follows the release rules for an intentional visual change.
[Automated review]
ff93c3b to
e512ed5
Compare
|
/approve-spec 9173976 |
There was a problem hiding this comment.
This pull request needs an engineering owner's decision before it can be approved: the new component:TreeList DD4 design decision and its verification row are what authorize moving every chevron and guide 4px toward the row's inline start, and because the same edit changes both the Design decisions table and the Verification map, it needs exact-head approval from a design owner and from an engineering owner. The /approve-spec already posted for this head covers the design side; an engineering owner records the remaining decision, or rejects it, by commenting /approve-spec <full head SHA> on this pull request, and the author may do so if they are an engineering owner. Nothing else blocks: labels, row geometry, theme targets and RTL mirroring are unchanged, the new browser test passes on this head and catches the old chevron margins, and the changeset follows the release rules for an intentional visual change.
[Automated review]
User impact
TreeList hierarchy guides align to the center of each expand/collapse chevron without shifting the interactive control. Labels remain in their existing position, and showing or hiding guides does not move the chevron.
Visual authority
Design decisionstable by a team design owner:component:TreeListDD4.Before and after
Matched Chromium capture of
Core/TreeList/Fully Expanded,lineGuides, light mode, 480 × 520 CSS px at 2× device scale.The label column is unchanged. The visible four-pixel movement is the chevron and its aligned guide moving to the chevron's natural column.
State matrix
lineGuides: guide centers equal chevron centers at every visible depth.noGuides: chevron centers are identical tolineGuides.Scope
Writing rubric results
R1 narration: none; DD4 states the component's present-tense visual contract.
R2 research: none in the record; browser measurements remain test and pull-request evidence.
R3 evidence: the verification row names the real-browser test and measured contract, not a change reference.
R4 rejected alternatives: none.
R5 change references: none.
R6 open questions: none.
Testing
TreeListGuideAlignment.interaction.browser.spec.tsin real Chromium: 3/3 passed for LTR, RTL, and guide visibility. The two natural-column cases fail againstmainwith the existing 4 px chevron compensation.pnpm exec vitest run packages/core/src/TreeList/TreeList.test.tsx --project ui: 105/105 passed.pnpm -F @astryxdesign/core typecheck: passed.pnpm -F @astryxdesign/core build: passed.pnpm storybook:build: passed.pnpm check:knowledge,pnpm check:changesets,pnpm check:sync, ESLint, Prettier, andgit diff --check: passed.