Skip to content

docs(core): the gesture arena's and host's doc comments sit on their declarations - #9114

Merged
cixzhang merged 1 commit into
meta:mainfrom
vjeux:uikit/f1-gesture-doc-comments
Oct 31, 2026
Merged

cixzhang merged 1 commit into
meta:mainfrom
vjeux:uikit/f1-gesture-doc-comments

Conversation

@vjeux

@vjeux vjeux commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Puts the five gesture doc comments astracat-bot flagged when approving #8076 onto the declarations they describe: comment moves only (one superseded duplicate goes), plus the changeset CI requires for core source.

…declarations

Comment moves only: stop's comment moves back above stop, inNextFrame's,
lastFed's and lastScroll's above theirs, and the superseded one-line
comment above watched's current one goes.
@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Oct 31, 2026 6:15am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR

🧪 Sandbox Preview

View Sandbox for this PR

No new or modified components detected.

Bundle Size Summary

Gzip figures measure each package's entry file, not the code an import pulls in.

Package Entry (ESM) Entry gzip before Entry gzip after Delta
@astryxdesign/core 4.9KB 1.2KB 1.2KB 0B
Package stylesheet Gzip before Gzip after Delta
@astryxdesign/core 36.0KB 36.0KB 0B

Accessibility Audit

Status: The accessibility audit did not run on this pull request. It runs after merges to main and before each release; pull requests that touch components run it with the ci:heavy-lanes label.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@astracat-bot

astracat-bot Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Oct 31, 2026, 6:41 AM UTC

@cixzhang cixzhang added the ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) label Oct 31, 2026
@cixzhang
cixzhang marked this pull request as ready for review October 31, 2026 06:33

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready: the five doc comments now sit on the declarations they describe, no executable line changes, and the [docs] changeset passes the repository's changeset checks. What remains is for the test jobs still running on this head to finish. Separately, the createAnimator options comment in motion/animator.ts that was flagged alongside these still sits above SetOptions, if you want to tidy it in a follow-up.

[Automated review]

@cixzhang
cixzhang merged commit be45737 into meta:main Oct 31, 2026
95 checks passed
@vjeux
vjeux deleted the uikit/f1-gesture-doc-comments branch October 31, 2026 07:33

This branch was successfully deployed

1 active deployment
Preview — 90fc3f5d Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants