Repository navigation
chore(FileInput): format the source with the repository's Prettier settings - #9263
Merged
Merged
Conversation
…ttings #9196 left FileInput.tsx unformatted; lint-staged then rewrites it in any local merge of main and those pull requests fail changeset coverage. Formatting only, with a [chore] patch Changeset.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
3 tasks done
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is ready to approve: the only code change is Prettier's own output for FileInput.tsx (formatting the base file gives exactly this head), and the patch [chore] Changeset passes the Changeset checks. Nothing is required before merge. If you edit the description: the unformatted lines came from #9031 rather than #9196, and 19 other non-test files under packages/core/src still fail prettier --check, so the stated invariant holds for FileInput only for now.
[Automated review]
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
packages/core/src/FileInput/FileInput.tsxlanded on main without Prettier formatting (from #9196). Lint doesn't check formatting at all, but the pre-commit formatter rewrites the file in any local merge of main that stages it. Pull requests that merge main locally therefore pick up a reformat of shipped source they never meant to change, and then fail "Check Changeset coverage". A separate pull request adds a formatting check on changed files to Lint, so this stops recurring.Intended invariant
Shipped source on main is Prettier-clean, so merging main never rewrites a file the pull request didn't change.
Change
prettier --writeonFileInput.tsx: one wrapped expression is joined onto a single line, and no tokens change. A patch Changeset in the "Other Changes" category covers the shipped file, as the coverage check requires for package source.Evidence
prettier --checkon main'sFileInput.tsxreports code style issues (the same trap chore(MultiSelector): format the source with the repository's Prettier settings #9247 closed for MultiSelector).prettier --checkpasses; the diff is whitespace and line breaks only.Scope
Testing
pnpm exec prettier --check packages/core/src/FileInput/FileInput.tsxpnpm check:changesetsPosted by Cindy's agent on her behalf.