Skip to content

spec(AST-094): withdraw #9423's three springs.contextMenu* FR4 rows until they are registered - #9434

Closed
cixzhang wants to merge 1 commit into
mainfrom
fix/revert-9423-fr4-rows
Closed

cixzhang wants to merge 1 commit into
mainfrom
fix/revert-9423-fr4-rows

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

main is red since #9423. packages/core/src/motion/roles.test.ts › "has exactly the roles spec:AST-094 FR4 names" reads the FR4 role table in docs/specs/AST-094-touch-presentations/spec.md and requires it to equal the registered motion roles. #9423 added three springs.contextMenu* rows that no code registers yet, so the UI unit tests fail on every pull request and on main's unit run and release-check, and merges are paused.

Change

This restores docs/specs/AST-094-touch-presentations/spec.md to its state before #9423, removing exactly what #9423 added there:

  • the three FR4 rows springs.contextMenuLift, springs.contextMenuDismiss and springs.contextMenuMorph, and the paragraph under the table that assigns them to component:ContextMenu;
  • the FR31 parenthetical "a lifted ContextMenu's menu grows on springs.contextMenuMorph";
  • the component:ContextMenu implementation-gap line about those three roles.

docs/specs/components/ContextMenu/ContextMenu.spec.md is unchanged. It still describes the lift and names the three springs; the ContextMenu batch re-adds the FR4 rows together with their registration. Record-only: no code, test, or Changeset.

Evidence

  • pnpm exec vitest run --project ui packages/core/src/motion/roles.test.ts: on main, 1 failed ("has exactly the roles spec:AST-094 FR4 names"); on this branch, 10 passed.
  • pnpm check:knowledge: "Knowledge templates and records are aligned."
  • Prettier check on the record passes.

Writing rubric results

This change removes rows and sentences, restoring the record's previously approved text verbatim. No new prose is introduced, and the restored text already passed the rubric when it was approved.

Scope

Posted by Cindy's agent on her behalf.

…ntil they are registered

The role registry test requires FR4's table to equal the registered motion
roles; the three rows #9423 added are not registered yet, turning main's UI
unit tests red. Restores the record to its pre-#9423 text; the ContextMenu
batch re-adds the rows with their registration.
@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 2, 2026 2:20am UTC

Request Review

@astracat-bot

astracat-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟡 Reviewed (for maintainers only) Nov 2, 2026, 2:25 AM UTC

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 2, 2026
@cixzhang
cixzhang marked this pull request as draft November 2, 2026 02:12
@cixzhang

cixzhang commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

/approve-spec 19956e1

@cixzhang
cixzhang marked this pull request as ready for review November 2, 2026 02:13

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. Removing the three springs.contextMenu* rows does make roles.test.ts pass again: it fails on main and passes on this branch. However, docs/specs/components/ContextMenu/ContextMenu.spec.md still says its lift and grow play on those roles "(spec:AST-094 FR4)" (FR5, lines 230–232 and the FR5 motion-roles verification row), and the restored FR31 now puts every anchored menu on springs.menuOpen, which contradicts ContextMenu's springs.contextMenuMorph. Please amend the ContextMenu record in this pull request to mark the three roles as withdrawn from FR4 until they are registered, keep their measured values there (otherwise the morph spring's damping ratio 0.8 and response 0.3 s are written down nowhere), and then record spec approval for the new head.

[Automated review]

its motion roles (FR4; a menu on `springs.menuOpen` and
`springs.menuClose`; a lifted ContextMenu's menu grows on
`springs.contextMenuMorph`). The shrink plays in full after the surface has
`springs.menuClose`). The shrink plays in full after the surface has

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the ContextMenu clause gone, this line puts every anchored menu on springs.menuOpen and springs.menuClose. docs/specs/components/ContextMenu/ContextMenu.spec.md FR5 (line 106) still says a touch-opened ContextMenu's menu grows on springs.contextMenuMorph "(spec:AST-094 FR4)", a row this PR removes. Amending that record here (FR5, lines 230–232, 248 and 268–269) to mark the three roles withdrawn until they are registered would keep the two records consistent.

@cixzhang

cixzhang commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #9432, which registers the three ContextMenu springs and keeps #9423's approved rows. Posted by Cindy's agent on her behalf.

@cixzhang cixzhang closed this Nov 2, 2026
@cixzhang
cixzhang deleted the fix/revert-9423-fr4-rows branch November 2, 2026 02:57

This branch was successfully deployed

1 active deployment
Preview — 19956e17 Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant