Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
/approve-spec 19956e1 |
There was a problem hiding this comment.
Requesting changes. Removing the three springs.contextMenu* rows does make roles.test.ts pass again: it fails on main and passes on this branch. However, docs/specs/components/ContextMenu/ContextMenu.spec.md still says its lift and grow play on those roles "(spec:AST-094 FR4)" (FR5, lines 230–232 and the FR5 motion-roles verification row), and the restored FR31 now puts every anchored menu on springs.menuOpen, which contradicts ContextMenu's springs.contextMenuMorph. Please amend the ContextMenu record in this pull request to mark the three roles as withdrawn from FR4 until they are registered, keep their measured values there (otherwise the morph spring's damping ratio 0.8 and response 0.3 s are written down nowhere), and then record spec approval for the new head.
[Automated review]
| its motion roles (FR4; a menu on `springs.menuOpen` and | ||
| `springs.menuClose`; a lifted ContextMenu's menu grows on | ||
| `springs.contextMenuMorph`). The shrink plays in full after the surface has | ||
| `springs.menuClose`). The shrink plays in full after the surface has |
There was a problem hiding this comment.
With the ContextMenu clause gone, this line puts every anchored menu on springs.menuOpen and springs.menuClose. docs/specs/components/ContextMenu/ContextMenu.spec.md FR5 (line 106) still says a touch-opened ContextMenu's menu grows on springs.contextMenuMorph "(spec:AST-094 FR4)", a row this PR removes. Amending that record here (FR5, lines 230–232, 248 and 268–269) to mark the three roles withdrawn until they are registered would keep the two records consistent.
Maintainer impact
mainis red since #9423.packages/core/src/motion/roles.test.ts› "has exactly the roles spec:AST-094 FR4 names" reads the FR4 role table indocs/specs/AST-094-touch-presentations/spec.mdand requires it to equal the registered motion roles. #9423 added threesprings.contextMenu*rows that no code registers yet, so the UI unit tests fail on every pull request and on main's unit run and release-check, and merges are paused.Change
This restores
docs/specs/AST-094-touch-presentations/spec.mdto its state before #9423, removing exactly what #9423 added there:springs.contextMenuLift,springs.contextMenuDismissandsprings.contextMenuMorph, and the paragraph under the table that assigns them tocomponent:ContextMenu;springs.contextMenuMorph";component:ContextMenuimplementation-gap line about those three roles.docs/specs/components/ContextMenu/ContextMenu.spec.mdis unchanged. It still describes the lift and names the three springs; the ContextMenu batch re-adds the FR4 rows together with their registration. Record-only: no code, test, or Changeset.Evidence
pnpm exec vitest run --project ui packages/core/src/motion/roles.test.ts: onmain, 1 failed ("has exactly the roles spec:AST-094 FR4 names"); on this branch, 10 passed.pnpm check:knowledge: "Knowledge templates and records are aligned."Writing rubric results
This change removes rows and sentences, restoring the record's previously approved text verbatim. No new prose is introduced, and the restored text already passed the rubric when it was approved.
Scope
Posted by Cindy's agent on her behalf.