Repository navigation
Conversation
…s an open question `triggerBehavior="toggle"` takes over the child button's press implicitly. Whether it stays that way or moves to an explicit pattern, with the caller's button calling show() and hide(), is an open API question. This records it, with no decision and no code change.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
Contributor
Author
|
Closing: covered by #9711's Tooltip open question. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact decision needed
None yet: an open API question on
component:Tooltip, whethertriggerBehavior="toggle"keeps taking over its child button's press implicitly, or moves to an explicit pattern where the caller's button callsshow()andhide().Existing authority searched
component:Tooltip(FR9–FR10, DEC log, Open questions: "None."),component:InfoTip, anduseTooltip'sTooltipReturn;useHoverCardalready returnsshow()andhide(), a precedent for the explicit option. Open PRs that edit Tooltip.spec.md (#9291, #9361) leave its Open questions section alone. No current claim decides between the two patterns.Decision
No decision: OQ1 records the question (
human-api, low priority), with no code change.Owner's text, adjusted for accuracy at main
The owner's text was: "OQ — Implicit toggle. With
triggerBehavior="toggle", Tooltip takes over its child button's press implicitly. Open: whether toggle stays implicit or moves to the explicit pattern InfoTip uses, where the caller's Button callsuseTooltip'sshow()andhide()."Two facts differ at main 4a8a76e, so the record words them as possibilities:
<Tooltip triggerBehavior="toggle">, the implicit path itself.useTooltipreturnsref,positionRef,interactionRef,anchorId,describedByandrenderTooltip, with noshow()orhide().Rejected alternatives
None; the question stays open.
Claim scope and non-goals
Only Open questions changes; no behavior, API or verification claim moves.
Evidence and implementation relationship
None; no implementation PR.
Writing rubric results
Scope
Validation
At 3ccce21:
pnpm check:knowledge, Prettier andgit diff --checkpass. The owner-gated record needs an engineering owner's/approve-spec.