Repository navigation
[Nexthop][bugfix] Start the fb303 stats-aggregation thread in the OSS fsdb server - #1743
Open
deepakgudiseva-nexthop wants to merge 2 commits into
Open
deepakgudiseva-nexthop wants to merge 2 commits into
deepakgudiseva-nexthop wants to merge 2 commits into
Conversation
…t it every fsdb fb303 counter reads 0. Signed-off-by: deepakgudiseva-nexthop <deepakgudiseva@nexthop.ai>
deepakgudiseva-nexthop
changed the title
Signed-off-by: Deepak Gudiseva <deepakgudiseva@nexthop.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
fsdb records its stats through
fb303::ThreadCachedServiceData, which buffers them per thread until a publish thread aggregates them into whatgetCounters()serves. Internal builds get that thread from the service framework infacebook/Server.cpp; the OSSoss/Server.cppnever starts it, so every thread-cached fsdb counter reads 0.The agent (
SwAgentInitializer), hw_agent (HwAgentMain) and qsfp_service (StatsPublisher) already start it themselves. This does the same for fsdb, at the same 1 s interval.fsdb.rssstill reads 0 in OSS becausegetMemoryUsage()is stubbed there; that is unchanged.Test Plan
OSS build on hardware,
fboss2 show fb303-counters --service fsdb --regex fb303_tcData_aggregate_call_count.sum, read twice 5 s apart:0 -> 012517 -> 12767