Repository navigation
feat: polish library and settings with window size presets - #746
Open
MohamedElGhandour wants to merge 1 commit into
Open
MohamedElGhandour wants to merge 1 commit into
MohamedElGhandour wants to merge 1 commit into
Conversation
Collaborator
|
I like this! Thanks! I can review all your work tonight, thanks for your contributions. |
Collaborator
|
If youre okay with fixing the one failing Ci, and applying the suggested edit, I will merge this! | play | art editor | graphics selection | settings, on the hero art, should stay centered per desktop size / resolution. (Left centered, on the hero image surface) And verify behavior is unchanged in the uninstalled portion by syncing a steam api key and ensuring that uninstalled game cards are also correctly presented. -- If you want me to cover these final changes let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Library controls become cramped or disproportionately small on large displays, and Settings mixes unrelated options in a long grid. This gives the library a shared responsive layout, groups Settings into focused categories, and adds saved window-size presets that keep desktop space visible.
Changes
PR Readiness (MANDATORY)
docs/development.md.Local toolchain
make testcommands passed.Test notes
Native macOS GPUI preview on a 3840 × 2160 logical display:
These previews use sample artwork and do not access production credentials or write preferences. Serialization and fallback are covered by tests; production preference persistence was not exercised against the user's profile. No real-game run is claimed for this UI commit.
The C suites skipped archive-based runtime simulation and Wine facade integration because the worktree lacks the runtime archives / MetalSharp Wine app. Existing fullscreen-to-windowed transition handling was not manually exercised.
Risk
Changes are confined to the native UI and its existing preferences file. Window sizes use logical points and fit within display bounds, with a 720 × 540 minimum. Invalid or missing stored presets fall back to Automatic. Reverting this commit restores the previous UI; no game data or runtime rollback is needed.
UI previews
Native offline previews with sample games. Large (4K) uses a 2800 × 1700 content window and leaves desktop space visible.
Library and carousel
Collection
Settings and window-size presets
SVG icons — close-up
Text glyphs were replaced by scalable vector assets; this native-size crop shows Play, edit, dropdown, and Settings controls.