Repository navigation
shows: treat a 201 on reset_show_progress as success - #318
Merged
Merged
Conversation
The contract (trakt-api 3c64fc4) answers POST shows/{id}/progress/watched/reset with 201 and
{reset_at}; the handler only printed its result on 200, so a successful reset printed nothing.
The route is VIP only: mock-tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
shows -a reset_show_progress: the contract (trakt-api3c64fc4) answersPOST shows/{id}/progress/watched/resetwith 201 and{reset_at}. The handler only printed its result on 200, so a successful reset printed nothing. It now accepts 201, and still accepts 200.The contract marks the route VIP only, so this is mock-tested only. The new handler test covers 201 with
-reset_at(body sent in UTC), 200, undo (204) and a missing-i.docs/shows.mdnow says reset and undo are VIP only.An AI assistant (Claude Code) wrote the fix and tests and drafted this description.