Add tabalways option to always show tab bar#4120
Open
artnc wants to merge 4 commits into
Open
Conversation
JoeKar
reviewed
Jun 21, 2026
Comment on lines
+465
to
+468
| * `tabalways`: always shows the tab bar, even when only one tab is open. | ||
|
|
||
| default value: `false` | ||
|
|
Member
There was a problem hiding this comment.
As is so often the case with new options, micro.json is overlooked.
Author
Member
There was a problem hiding this comment.
Since it is often forgotten (from us too) or simply ignored and it breaks with single point of truth/failure I'm inclined to drop it as well.
JoeKar
approved these changes
Jun 22, 2026
dmaluka
reviewed
Jun 22, 2026
| func NewTabList(bufs []*buffer.Buffer) *TabList { | ||
| w, h := screen.Screen.Size() | ||
| iOffset := config.GetInfoBarOffset() | ||
| numBufs := len(bufs) |
Collaborator
There was a problem hiding this comment.
I don't think this actually improves anything. The length of a slice is not "calculated" every time len(bufs) is called, it is internally stored as a part of the slice data structure by Go runtime.
This reverts commit 49a160c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #4017 and picks up where #3882 left off, which @dmaluka supported.
cc @dmaluka @1ynxy @dave-foxglove @JoeKar