Skip to content

fix: drop ignoreHTTPSErrors from launch - #883

Merged
Kikobeats merged 3 commits into
masterfrom
fix/accept-insecure-certs
Aug 17, 2026
Merged

fix: drop ignoreHTTPSErrors from launch#883
Kikobeats merged 3 commits into
masterfrom
fix/accept-insecure-certs

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Puppeteer ≥23 dropped ignoreHTTPSErrors as a silent no-op.
  • Stop passing it. Do not set acceptInsecureCerts — Puppeteer default is false.

Test plan

  • pnpm exec ava test/driver.unit.js (from packages/browserless)

Note

Low Risk
Small API cleanup aligned with Puppeteer 23; default cert validation is unchanged from the intended Puppeteer default.

Overview
Removes ignoreHTTPSErrors from browser launch because Puppeteer ≥23 no longer supports it as a launch option (it was a silent no-op). driver.js no longer defaults or forwards that flag into puppeteer.launch / connect; callers still pass other options via ...launchOpts.

Docs and the screencast example no longer show ignoreHTTPSErrors: true in createBrowser() samples. TLS behavior now follows Puppeteer’s defaults (e.g. acceptInsecureCerts stays at false unless callers set it explicitly).

Reviewed by Cursor Bugbot for commit 95a13a6. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Changes
    • Removed the ignoreHTTPSErrors browser configuration option from initialization examples.
    • Browser startup no longer applies the HTTPS error bypass setting.
    • Existing lossyDeviceName behavior remains enabled.

Puppeteer 23 dropped the old launch key as a silent no-op.
Keep both so MITM proxies still work on current Puppeteer.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a1d300c8-f1f3-4061-af90-958f5a505eb8

📥 Commits

Reviewing files that changed from the base of the PR and between c8ee027 and 95a13a6.

📒 Files selected for processing (3)
  • README.md
  • packages/browserless/src/driver.js
  • packages/screencast/examples/server.js
💤 Files with no reviewable changes (1)
  • packages/browserless/src/driver.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • README.md
  • packages/screencast/examples/server.js

Included review availability: Your plan includes up to 4 reviews per rolling hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change removes ignoreHTTPSErrors from browser launch options and examples. The configurations retain lossyDeviceName: true.

Changes

HTTPS error option removal

Layer / File(s) Summary
Remove HTTPS error configuration
packages/browserless/src/driver.js, README.md, packages/screencast/examples/server.js
spawn no longer defines or forwards ignoreHTTPSErrors. The README and screencast example no longer show the option.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 95a13

This change removes an obsolete HTTPS-error launch option while retaining the documented secure default; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of ignoreHTTPSErrors from the launch configuration.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/accept-insecure-certs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Puppeteer 23 dropped the old launch key as a silent no-op.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Kikobeats Kikobeats changed the title fix: map ignoreHTTPSErrors to acceptInsecureCerts fix: pass acceptInsecureCerts instead of ignoreHTTPSErrors Aug 17, 2026
Puppeteer 23 made the old key a no-op. Leave acceptInsecureCerts
at its default (false) instead of setting it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Kikobeats Kikobeats changed the title fix: pass acceptInsecureCerts instead of ignoreHTTPSErrors fix: drop ignoreHTTPSErrors from launch Aug 17, 2026
@coveralls

coveralls commented Aug 17, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 80.277%fix/accept-insecure-certs into master. No base build found for master.

@Kikobeats
Kikobeats merged commit 48cdfaf into master Aug 17, 2026
23 checks passed
@Kikobeats
Kikobeats deleted the fix/accept-insecure-certs branch August 17, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants