fix: drop ignoreHTTPSErrors from launch - #883
Conversation
Puppeteer 23 dropped the old launch key as a silent no-op. Keep both so MITM proxies still work on current Puppeteer. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change removes ChangesHTTPS error option removal
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes an obsolete HTTPS-error launch option while retaining the documented secure default; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Puppeteer 23 dropped the old launch key as a silent no-op. Co-authored-by: Cursor <cursoragent@cursor.com>
Puppeteer 23 made the old key a no-op. Leave acceptInsecureCerts at its default (false) instead of setting it. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
ignoreHTTPSErrorsas a silent no-op.acceptInsecureCerts— Puppeteer default isfalse.Test plan
pnpm exec ava test/driver.unit.js(frompackages/browserless)Note
Low Risk
Small API cleanup aligned with Puppeteer 23; default cert validation is unchanged from the intended Puppeteer default.
Overview
Removes
ignoreHTTPSErrorsfrom browser launch because Puppeteer ≥23 no longer supports it as a launch option (it was a silent no-op).driver.jsno longer defaults or forwards that flag intopuppeteer.launch/connect; callers still pass other options via...launchOpts.Docs and the screencast example no longer show
ignoreHTTPSErrors: trueincreateBrowser()samples. TLS behavior now follows Puppeteer’s defaults (e.g.acceptInsecureCertsstays atfalseunless callers set it explicitly).Reviewed by Cursor Bugbot for commit 95a13a6. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
ignoreHTTPSErrorsbrowser configuration option from initialization examples.lossyDeviceNamebehavior remains enabled.