You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CorrelationHeaderDomains and CorrelationHeaderExcludedDomains has bad matchers #2456
I'm not sure its worthy of a security thing, as this is just correlations and set in frontend code, but it seems like a bug that may trip someone up. Either the lists should take in a real regex or the matching logic should be tightened.
Both the include and exclude lists are "contains" (and may contain (some) regex...)
day.example.com will also match monday.example.com (and day.example.com.otherdomain.net) bar.net will also match foobar.net
the same with excludedDomains where bar.example.com will exclude foobar.example.com. (and bar.example.com.otherdomain.net)
The semi regex will work, but not if it contains a backwards slash or a ..
I would suggest making the existing ones match exact domain if there is no wildcard at start. And I would create a regex overload for both so we can use real regexes to match.
Activity
github-actions commentedon Aug 8, 2025
This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.
Strepto commentedon Aug 11, 2025
Unstale.
github-actions commentedon Apr 9, 2026
This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.
Strepto commentedon Apr 9, 2026
Relevant
github-actions commentedon Nov 1, 2026
This issue has had no activity for 90 days and will be closed in 14 days. Comment or add the "keep" label to prevent closure.
Strepto commentedon Nov 2, 2026
Not fixed