Repository navigation
Fix core performance test imports - #2789
Merged
Jackson Weber (JacksonWeber) merged 1 commit intoOct 22, 2026
Merged
Jackson Weber (JacksonWeber) merged 1 commit into
Jackson Weber (JacksonWeber) merged 1 commit into
Conversation
Use the current enum, diagnostic logger, and helper module paths after the core source reorganization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All three replacement paths resolve to the expected exports, and the change is limited to test imports.
No open issues 🎉
What changed in this PR
Fixes core performance-test compilation by aligning imports with the reorganized source layout. SDK behavior and test logic are unchanged.
Changes:
- Updates the logging enum, diagnostic logger, and helper-function imports to their current paths.
| File | Description |
|---|---|
shared/AppInsightsCore/Tests/Perf/src/CorePerfCheck.Tests.ts |
Corrects three outdated source import paths. |
Review effort: Balanced
Radhika Gupta (rads-1996)
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update three imports in the core performance tests to match the reorganized source paths:
enums/ai/LoggingEnumsdiagnostics/DiagnosticLoggerutils/HelperFuncsThis fixes performance-test compilation without changing SDK behavior. The PR contains one commit changing only
shared/AppInsightsCore/Tests/Perf/src/CorePerfCheck.Tests.ts.Validation
--parallelism 1), all 16 performance tests, and all 2,472 unit tests passed using Node 20.20.0 and Rush 5.178.1. The installed Rush executable was used because the npm bootstrap encountered registry TLS/cache failures.main.Companion draft PR addressing the parallel-build
.aiAutoMinify.jsonrace in the 1DS pipeline: https://dev.azure.com/msazure/One/_git/1DS.JavaScript/pullrequest/17624061