Skip to content

Fix core performance test imports - #2789

Merged
Jackson Weber (JacksonWeber) merged 1 commit into
microsoft:mainfrom
JacksonWeber:fix-core-perf-imports
Oct 22, 2026
Merged

Jackson Weber (JacksonWeber) merged 1 commit into
microsoft:mainfrom
JacksonWeber:fix-core-perf-imports

Conversation

@JacksonWeber

Copy link
Copy Markdown
Contributor

Summary

Update three imports in the core performance tests to match the reorganized source paths:

  • enums/ai/LoggingEnums
  • diagnostics/DiagnosticLogger
  • utils/HelperFuncs

This fixes performance-test compilation without changing SDK behavior. The PR contains one commit changing only shared/AppInsightsCore/Tests/Perf/src/CorePerfCheck.Tests.ts.

Validation

  • On the upstream-main-based fix branch, Node 20 lint-fix and core performance-test compilation passed. The first performance run had one timing-threshold failure; an unchanged retry passed all 15 tests.
  • On the original checkout, a serialized rebuild (--parallelism 1), all 16 performance tests, and all 2,472 unit tests passed using Node 20.20.0 and Rush 5.178.1. The installed Rush executable was used because the npm bootstrap encountered registry TLS/cache failures.
  • The full rebuild and unit suite were not rerun after moving the fix onto upstream main.

Companion draft PR addressing the parallel-build .aiAutoMinify.json race in the 1DS pipeline: https://dev.azure.com/msazure/One/_git/1DS.JavaScript/pullrequest/17624061

Use the current enum, diagnostic logger, and helper module paths after the core source reorganization.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@JacksonWeber
Jackson Weber (JacksonWeber) marked this pull request as ready for review October 22, 2026 01:25
@JacksonWeber
Jackson Weber (JacksonWeber) requested a review from a team as a code owner October 22, 2026 01:25
Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All three replacement paths resolve to the expected exports, and the change is limited to test imports.

No open issues 🎉

What changed in this PR

Fixes core performance-test compilation by aligning imports with the reorganized source layout. SDK behavior and test logic are unchanged.

Changes:

  • Updates the logging enum, diagnostic logger, and helper-function imports to their current paths.
File Description
shared/​AppInsightsCore/​Tests/​Perf/​src/​CorePerfCheck.Tests.ts Corrects three outdated source import paths.

Review effort: Balanced

@JacksonWeber
Jackson Weber (JacksonWeber) merged commit 26a701a into microsoft:main Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants