Repository navigation
fix: require patched Node runtimes for repository builds - #2791
Merged
Hector Hernandez (hectorhdzg) merged 2 commits intoOct 23, 2026
Merged
Conversation
Use supported Node security floors for CI, CodeQL, Pages, npm, and Rush. Resolve current patches instead of accepting vulnerable cached runtimes and document runner provisioning requirements. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Radhika Gupta (rads-1996)
approved these changes
Oct 23, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Blocked dependency restoration leaves full install, build, and lint compatibility unverified across the newly required runtimes.
No open issues 🎉
What changed in this PR
This PR hardens repository builds by requiring patched Node.js runtimes without changing browser SDK compatibility or telemetry compression.
Changes:
- Add matching npm and Rush runtime constraints, strict npm engine checks, and a local Node version default.
- Replace Node 18/20 CI jobs with supported runtime ranges and enable latest-patch selection.
- Document security minimums and separate patching responsibilities for action runtimes and release infrastructure.
| File | Description |
|---|---|
rush.json |
Require patched Node versions for Rush tooling. |
package.json |
Declare matching Node engine requirements. |
CONTRIBUTING.md |
Document runtime requirements and infrastructure patching responsibilities. |
.nvmrc |
Select Node 24.22.1 for local development. |
.npmrc |
Enable strict npm engine enforcement. |
.github/workflows/jekyll-gh-pages.yml |
Explicitly select patched Node 24 with latest-patch checks. |
.github/workflows/codeql-analysis.yml |
Update the configured Node runtime to patched Node 24. |
.github/workflows/ci.yml |
Test patched Node 22/24/26 ranges with latest-patch checks. |
Review effort: Balanced
Keep the Rush override and lockfile on decode-uri-component 0.5.0 so full dependency resolution cannot select a version without the required CommonJS patch. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jackson Weber (JacksonWeber)
approved these changes
Oct 23, 2026
Hector Hernandez (hectorhdzg)
deleted the
hectorhdzg-harden-build-node-runtimes
branch
October 23, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrc, and contributor guidance for CVE-2026-111497 and separately managed runner runtimes.Recent CI logs showed Node 22.23.3 and 24.21.0, below the security fixes, as well as EOL Node 18/20. This is build/install/runtime hardening; browser SDK gzip compression is unchanged.
Validation
.nvmrcagree.check-latest.git diff --check.pnpm@10.34.5pin is unavailable from the configured registry. Direct Grunt execution skips ESLint on Node 24 under the existing configuration.Operational follow-up
JavaScript actions use the runner's bundled Node runtime independently of
actions/setup-node. Those runtimes, private release agents, and external container images still require provisioning-side patch verification; this PR does not claim to update them.