Enforce permissions when reviewing orphaned extension data - #9844
Open
jhejlsberg wants to merge 1 commit into
Open
Enforce permissions when reviewing orphaned extension data#9844jhejlsberg wants to merge 1 commit into
jhejlsberg wants to merge 1 commit into
Conversation
<!-- Thanks for contributing to BCApps! A few things before you hit "Create pull request": - Your PR must link to an approved issue. New here? See CONTRIBUTING.md. - You must have built and run your change yourself. CI is a safety net, not a substitute. - If you used AI or an agent to write this PR, you are still the author. Read the diff, build it, and try it before requesting review. Contributing guide: https://github.com/microsoft/BCApps/blob/main/CONTRIBUTING.md Local dev environment: https://github.com/microsoft/BCApps/blob/main/LOCAL_DEV_ENV.md --> ## What & why <!-- A few sentences: what does this change do, and what problem does it solve? --> Ensure marking orphaned extension data as reviewed consistently calls CheckPermissions() from both the notification and page actions. ## Linked work <!-- Required: link an approved GitHub issue using "Fixes #<number>". Microsoft contributors: also link the ADO work item with "AB#<number>" if you have one. --> Fixes [AB#633514](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/633514) ## How I validated this - [x] I read the full diff and it contains only changes I intended. - [x] I built the affected app(s) locally with no new analyzer warnings. - [x] I ran the change in Business Central and confirmed it behaves as expected. - [ ] I added or updated tests for the new behavior, or explained below why none are needed. No tests added; both entry points now share the same implementation. **What I tested and the outcome** *(required — be specific: scenarios, commands, screenshots for UI changes)* <!-- Example: - Ran the new "Post and Send" action on a sales invoice in a fresh container; document posted and email queued (see screenshot). - New unit tests in MyFeatureTest.Codeunit.al pass locally; full module test suite green. - No tests added because change is comment-only / refactor with existing coverage. --> - Installed and uninstalled an extension; verified the orphaned-data notification appeared. - Marked data as reviewed from both the notification and the Delete Orphaned Extension Data page; verified the reviewed status was updated. - Reinstalled and uninstalled the extension; verified the reviewed status was reset. ## Risk & compatibility <!-- Anything reviewers should watch for: breaking changes, upgrade/data impact, permissions, telemetry, feature flags, follow-up work. Write "None" if there's nothing to call out. --> Permission enforcement is stricter on OpenPage.
jhejlsberg
marked this pull request as draft
July 30, 2026 09:20
jhejlsberg
marked this pull request as ready for review
July 30, 2026 12:15
nhsejth
approved these changes
Jul 31, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Backports PR #9569 to 28.x.
Ensure marking orphaned extension data as reviewed consistently calls CheckPermissions() from both the notification and page actions.
Linked work
Fixes AB#633514
How I validated this
No tests added; both entry points now share the same implementation.
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility
Permission enforcement is stricter on OpenPage.