Skip to content

[Extensibility Request] issue 29078: Add OnBeforeTestTransferLine event #9864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AleksandricMarko wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Extensibility Request] issue 29078: Add OnBeforeTestTransferLine event #9864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Layers/IT/BaseApp/Inventory/Transfer/TransferHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,8 @@ table 5740 "Transfer Header"
var
DummyTrackingSpecification: Record "Tracking Specification";
begin
OnBeforeTestTransferLine(TransferLine, Ship);

if Ship then
DummyTrackingSpecification.CheckItemTrackingQuantity(Database::"Transfer Line", 0, "No.", TransferLine."Line No.",
TransferLine."Qty. to Ship (Base)", TransferLine."Qty. to Ship (Base)", true, false)
Expand Down Expand Up @@ -2168,4 +2170,9 @@ table 5740 "Transfer Header"
local procedure OnUpdateTransLinesOnAfterUpdateFromDirectTransfer(var TransferLine: Record "Transfer Line"; TempTransferLine: Record "Transfer Line")
begin
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeTestTransferLine(TransferLine: Record "Transfer Line"; Ship: Boolean)
begin
end;
}
7 changes: 7 additions & 0 deletions src/Layers/NA/BaseApp/Inventory/Transfer/TransferHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,6 +1664,8 @@ table 5740 "Transfer Header"
var
DummyTrackingSpecification: Record "Tracking Specification";
begin
OnBeforeTestTransferLine(TransferLine, Ship);

if Ship then
DummyTrackingSpecification.CheckItemTrackingQuantity(Database::"Transfer Line", 0, "No.", TransferLine."Line No.",
TransferLine."Qty. to Ship (Base)", TransferLine."Qty. to Ship (Base)", true, false)
Expand Down Expand Up @@ -2053,4 +2055,9 @@ table 5740 "Transfer Header"
local procedure OnUpdateTransLinesOnAfterUpdateFromDirectTransfer(var TransferLine: Record "Transfer Line"; TempTransferLine: Record "Transfer Line")
begin
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeTestTransferLine(TransferLine: Record "Transfer Line"; Ship: Boolean)
begin
end;
}
7 changes: 7 additions & 0 deletions src/Layers/RU/BaseApp/Inventory/Transfer/TransferHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1592,6 +1592,8 @@ table 5740 "Transfer Header"
var
DummyTrackingSpecification: Record "Tracking Specification";
begin
OnBeforeTestTransferLine(TransferLine, Ship);

if Ship then
DummyTrackingSpecification.CheckItemTrackingQuantity(Database::"Transfer Line", 0, "No.", TransferLine."Line No.",
TransferLine."Qty. to Ship (Base)", TransferLine."Qty. to Ship (Base)", true, false)
Expand Down Expand Up @@ -1981,4 +1983,9 @@ table 5740 "Transfer Header"
local procedure OnUpdateTransLinesOnAfterUpdateFromDirectTransfer(var TransferLine: Record "Transfer Line"; TempTransferLine: Record "Transfer Line")
begin
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeTestTransferLine(TransferLine: Record "Transfer Line"; Ship: Boolean)
begin
end;
}
7 changes: 7 additions & 0 deletions src/Layers/W1/BaseApp/Inventory/Transfer/TransferHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,6 +1573,8 @@ table 5740 "Transfer Header"
var
DummyTrackingSpecification: Record "Tracking Specification";
begin
OnBeforeTestTransferLine(TransferLine, Ship);

@github-actions github-actions Bot Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Performance}$

CheckTransferLines calls TestTransferLine once per transfer line inside a FindSet/repeat loop, so the new OnBeforeTestTransferLine publisher now fires once per row. Total cost scales with line count and with every subscriber attached to the event. If a batch-level hook is sufficient, move the extensibility point outside the loop; otherwise keep subscribers guarded and free of database work on the hot path.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.26.4


if Ship then
DummyTrackingSpecification.CheckItemTrackingQuantity(Database::"Transfer Line", 0, "No.", TransferLine."Line No.",
TransferLine."Qty. to Ship (Base)", TransferLine."Qty. to Ship (Base)", true, false)
Expand Down Expand Up @@ -1962,4 +1964,9 @@ table 5740 "Transfer Header"
local procedure OnUpdateTransLinesOnAfterUpdateFromDirectTransfer(var TransferLine: Record "Transfer Line"; TempTransferLine: Record "Transfer Line")
begin
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeTestTransferLine(TransferLine: Record "Transfer Line"; Ship: Boolean)
begin
end;
}
Loading