Skip to content

Add missing telemetry event IDs to E-Document Session.LogMessage calls - #9872

Merged
Groenbech96 merged 1 commit into
mainfrom
telemetry/add-missing-event-ids-edocument
Aug 3, 2026
Merged

Add missing telemetry event IDs to E-Document Session.LogMessage calls#9872
Groenbech96 merged 1 commit into
mainfrom
telemetry/add-missing-event-ids-edocument

Conversation

@Groenbech96

@Groenbech96 Groenbech96 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

21 Session.LogMessage call sites in the E-Document apps passed an empty string ('') as the telemetry event ID, so the traces they emit cannot be aggregated, filtered or alerted on by event ID in the standard telemetry pipeline.

Most notably, every single Session.LogMessage call in the Avalara E-Document connector was untagged (20 of 20) — that app is effectively invisible in telemetry when querying by event ID. It does set 'Category' custom dimensions, so the messages aren't completely untraceable, but they can't be grouped or monitored the normal way.

One further call in the core E-Document app (EDocumentPEPPOLHandler.Codeunit.al) was also missing its tag; the rest of that app already follows the convention.

Change

Tags were allocated by running Expand-TelemetryTags, which reserves IDs centrally, so there is no collision risk. They cover the contiguous range 0000UVW0000UWG.

File Tags
Avalara/App/src/Shared/AvalaraFunctions.Codeunit.al 0000UVW0000UW0
Avalara/App/src/Documents/AvalaraDocumentManagement.Codeunit.al 0000UW10000UW5
Avalara/App/src/Connection/HttpExecutor.Codeunit.al 0000UW60000UW9
Avalara/App/src/Maintenance/Maintenance.Codeunit.al 0000UWA0000UWC
Avalara/App/src/Activation/Activation.Codeunit.al 0000UWD, 0000UWE
Avalara/App/src/Integration/Processing.Codeunit.al 0000UWF
EDocument/App/src/Processing/Import/StructureReceivedEDocument/EDocumentPEPPOLHandler.Codeunit.al 0000UWG

AB#644900

21 `Session.LogMessage` call sites passed an empty string ('') as the
telemetry event ID, so the emitted traces could not be aggregated or
alerted on by event ID.

All 20 `Session.LogMessage` calls in the Avalara E-Document connector
were untagged, making that app effectively invisible in telemetry when
querying by event ID. One further call in the core E-Document app
(EDocumentPEPPOLHandler) was also missing its tag.

Tags were allocated by `Expand-TelemetryTags` and cover the contiguous
range 0000UVW-0000UWG. Only the event ID literal changed on each line;
no message, verbosity, data classification, scope or custom dimension
was modified.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7f568c52-2a16-40db-828d-64ffd2dfb87b
@Groenbech96
Groenbech96 requested review from a team July 31, 2026 10:01
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Integration GitHub request for Integration area labels Jul 31, 2026
@Groenbech96
Groenbech96 enabled auto-merge August 3, 2026 07:49
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 3, 2026
@Groenbech96
Groenbech96 added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit cad73c8 Aug 3, 2026
330 of 337 checks passed
@Groenbech96
Groenbech96 deleted the telemetry/add-missing-event-ids-edocument branch August 3, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Integration GitHub request for Integration area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants