Fixes #8869: French sales reports must ignore comment lines when evaluating GetGoodsAndServicesText - #9879
Open
nicolassaleron wants to merge 1 commit into
Open
Conversation
…valuating GetGoodsAndServicesText
github-actions
Bot
added
From Fork
nicolassaleron
marked this pull request as ready for review
July 31, 2026 15:06
github-actions
Bot
added
the
needs-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #8869. This issue is only related to the French localization.
Issue: comment lines are considered are services when the GetGoodsAndServicesText is executed when printing sales invoice and credit memos.
Solution: comment lines are filtered out.