Skip to content

fix(reflection): review final refinement#433

Merged
james-tn merged 1 commit into
mainfrom
fix/reflection-final-review
Jul 13, 2026
Merged

fix(reflection): review final refinement#433
james-tn merged 1 commit into
mainfrom
fix/reflection-final-review

Conversation

@james-tn

Copy link
Copy Markdown
Contributor

Summary

  • review every refined response, including the final allowed refinement
  • require the reviewer response to equal the normalized APPROVE token
  • add regression coverage for the final-review bypass and approval substring false positives

Testing

  • agentic_ai/applications/.venv/Scripts/python.exe -m pytest tests/test_agent_framework_1_2_1_regression.py -v --tb=short
  • 65 passed

Fixes #432

@james-tn
james-tn merged commit f6d1a23 into main Jul 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: agentic_ai/.../reflection_agent.py — final refinement is returned to user without reviewer ever seeing it

1 participant