Repository navigation
Restrict semantic variable lookup to session scope - #17
Merged
Yuqing (mydmdm) merged 1 commit intoOct 14, 2026
Merged
Yuqing (mydmdm) merged 1 commit into
Yuqing (mydmdm) merged 1 commit into
Conversation
Prevent authenticated sessions from resolving global constant-prefix variables through the public semantic-variable API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scan result coverage
95c40883-b36e-411c-9fe8-b1c4b44e0d6b: fixed.SemanticVariableManager.get_var(session_id, var_id)now resolves only the supplied session's local namespace.8d430218-3d21-4231-88e8-c17fdc0bdc9a: stale evidence. PR Security hotfix: remediate authentication, code execution, and SSRF findings #16 already changed/register_engineto return403without parsing the request or invoking ServeCore. The existing security regression test continues to cover that behavior.Security impact
Before this change, a caller with a valid session capability and a leaked global constant-prefix
var_idcould read that prefix through the public semantic-variable endpoint. IDs are not externally derivable and constant prefixes are already filled, which limited exploitability, but identifier secrecy is not an ownership control.Validation
py_compilegit diff --check