Honor login encryption options for Relog DSN that imports Perfmon - #555
Open
JosephPilov-MSFT (PiJoCoder) wants to merge 2 commits into
Open
Honor login encryption options for Relog DSN that imports Perfmon #555JosephPilov-MSFT (PiJoCoder) wants to merge 2 commits into
JosephPilov-MSFT (PiJoCoder) wants to merge 2 commits into
Conversation
Configure the ODBC DSN used by relog.exe to respect the Encrypt and Trust Server Certificate options the user selects when connecting SqlNexus to SQL Server, and modernize DSN driver selection. Changes: - BLGImporter: read Encrypt/TrustServerCertificate from the connection string and propagate them into the DSN so relog negotiates the same transport security as the rest of the app. - DSNCreator: append Encrypt and TrustServerCertificate keywords; try modern drivers first (ODBC Driver 18 -> 17 -> legacy "SQL Server") with logging and graceful fallback. - Extract BuildDsnSettings() as a testable helper (P/Invoke stays out of unit tests). - Rename DSN from "Nexus" to "SQLNexusDSN" via a shared constant so the registration and relog "-o SQL:<DSN>!<db>" argument stay in sync. - Add DSNCreatorTests (6 MSTest cases) and reference PerfmonImporter from the unit test project.
…elogEncryptConnection_pijocoder
JosephPilov-MSFT (PiJoCoder)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.