Skip to content

fix: use semantic button elements for in-page actions (a11y MAS 4.1.2) #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
navya9singh wants to merge 1 commit into
base: v2
Choose a base branch
from
+13 −7
Draft

fix: use semantic button elements for in-page actions (a11y MAS 4.1.2) #3593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/typescriptlang-org/src/components/index/AboveTheFold.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const Row = (props: { children: any, className?: string }) => <div className={[p
const Col = (props: { children: any, className?: string }) => <div className={[props.className, "col1"].join(" ")}>{props.children}</div>
const Col2 = (props: { children: any }) => <div className="col2">{props.children}</div>

const FluidButton = (props: { href?: string, onClick?: any, title: string, subtitle?: string, icon: JSX.Element, className?: string }) => (
<a className={"fluid-button " + props.className || ""} href={props.href} onClick={props.onClick}>
const FluidButton = (props: { href?: string, onClick?: any, title: string, subtitle?: string, icon: JSX.Element, className?: string, role?: string }) => (
<a className={"fluid-button " + props.className || ""} href={props.href} onClick={props.onClick} role={props.role}>
<div>
<div className="fluid-button-title">{props.title}</div>
<div className="fluid-button-subtitle">{props.subtitle}</div>
Expand Down Expand Up @@ -43,6 +43,7 @@ export const AboveTheFold = () => {
subtitle={i("index_2_cta_install_subtitle")}
href="/download"
onClick={onclick}
role="button"
icon={
<svg width="21" height="5" viewBox="0 0 21 5" fill="none" xmlns="http://www.w3.org/2000/svg">
<rect x="0.5" y="0.5" width="4" height="4" stroke="black" />
Expand Down Expand Up @@ -122,11 +123,11 @@ export const AboveTheFold = () => {
const Content = window.innerWidth < 600 ? CTAHeadlineMobile : CTAHeadlines
return (
<div className="cta">
<a className="transparent-button" onClick={() => setShowCTALinks(false)} href="#">
<button className="transparent-button" onClick={() => setShowCTALinks(false)}>
<svg width="21" height="14" viewBox="0 0 21 14" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M20.25 7.75L1.75 7.75M1.75 7.75L7.75 1.25M1.75 7.75L7.75 13.25" stroke="white" strokeWidth="2" />
</svg>
Back</a>
Back</button>
<Content />
</div>
)
Expand Down
5 changes: 2 additions & 3 deletions packages/typescriptlang-org/src/components/index/EditorExamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ export const EditorExamples = () => {

</div>

<a
<button
className="next-headline-button"
href="#"
onClick={next}
aria-label="Show code sample"
>
Expand All @@ -85,7 +84,7 @@ export const EditorExamples = () => {
>
<path d="M0 14.5V0.5L10.5 7L0 14.5Z" />
</svg>
</a>
</button>
</div>
);
};
6 changes: 6 additions & 0 deletions packages/typescriptlang-org/src/templates/pages/css/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ $headline-foreground-bg: white;
padding: 1rem 1rem;
text-decoration: none;
cursor: pointer;
border: none;
font-family: inherit;
font-size: inherit;

@media screen and (-ms-high-contrast: active) {
border: 2px solid grey;
Expand Down Expand Up @@ -1281,6 +1284,9 @@ $headline-foreground-bg: white;
width: 80px;
padding: 10px;
cursor: pointer;
background: none;
font-family: inherit;
font-size: inherit;
svg {
margin-right: 8px;
}
Expand Down
Loading