Repository navigation
fix(verl): classify trajectory prefix mismatch diagnostics - #646
Open
Daniel Peng (original4422) wants to merge 1 commit into
Open
Daniel Peng (original4422) wants to merge 1 commit into
Daniel Peng (original4422) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #645. Classify the existing, capped mismatch diagnostics without changing token-prefix merge decisions:
Template normalization recognizes only literal
<think>,</think>,<tool_call>and</tool_call>delimiters plus whitespace. It retains their content and unknown tags, rejects an empty normalized context, and falls back tootherwithout a tokenizer or on decoding failure. These flags are heuristics, not proof of the underlying cause. The table schema, 100-row cap and training metrics are unchanged.Evidence
other.After: all 10 cases pass, including content changes, unknown delimiters, empty normalized context, decoding failure and absent-tokenizer controls.
uv run --locked --no-sync pytest -v --durations=20 tests: 159 passed, 3 dependency warnings (child-only inherited proxy variables removed for localhost tests).pre-commit run --all-files --show-diff-on-failure,ruff check .,ruff format --check .,python scripts/check_headers.py, andpyright: passed.uv build --no-sourcesanduv run --locked --no-sync mkdocs build --strict: passed.This bounded change does not cover arbitrary tokenizer special tokens, semantically equivalent tool-call JSON, Qwen corpus evaluation, optional diagnostic counters or merge-precondition documentation from the broader proposal. It keeps unrecognized cases as
other.Developed and validated with OpenAI Codex assistance. No GPU training, model inference or corpus-level classification/performance evaluation was run.
Merge Danger
Door: two-way
Blast Radius: diagnostics
This only changes flags on already-recorded mismatch rows. Strict token-prefix splitting and training batches are preserved; unfamiliar template changes conservatively remain
other.