Skip to content

fix(server): tolerate overflowing logprobs in triplet queries #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ningyixi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): tolerate overflowing logprobs in triplet queries #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agentlightning/server/routes/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _extract_choice_log_probs(choice: dict[str, Any]) -> list[float] | None:
for v in raw:
try:
f = float(v)
except (TypeError, ValueError):
except (TypeError, ValueError, OverflowError):
return None
if not math.isfinite(f):
return None
Expand Down
33 changes: 33 additions & 0 deletions tests/server/test_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,39 @@ def test_delete_rollout(client: TestClient, auth_headers: dict[str, str]):
assert client.delete(f"/api/rollouts/{rollout_id}", headers=auth_headers).status_code == 204


@pytest.mark.parametrize(
"logprobs",
[
{"content": [{"logprob": -0.5}, {"logprob": 10**400}]},
{"token_logprobs": [-0.5, 10**400]},
],
ids=["chat", "completions"],
)
def test_triplet_events_ignore_overflowing_logprobs(client: TestClient, auth_headers: dict[str, str], logprobs: dict):
rollout_id = _rollout(client, auth_headers)["rollout_id"]
posted = client.post(
f"/api/rollouts/{rollout_id}/attempt/0/events",
json={
"event_type": "model_request",
"data": {
"response": {
"prompt_token_ids": [1, 2],
"choices": [{"token_ids": [3, 4], "logprobs": logprobs}],
},
},
},
headers=auth_headers,
)
assert posted.status_code == 200

triplets = client.get(f"/api/rollouts/{rollout_id}/events?format=triplet", headers=auth_headers)
assert triplets.status_code == 200
data = triplets.json()[0]["data"]
assert data["prompt_token_ids"] == [1, 2]
assert data["response_token_ids"] == [3, 4]
assert data["response_log_probs"] is None


def test_enqueue_with_client_rollout_id_is_idempotent(client: TestClient, auth_headers: dict[str, str]):
rid = "fixed-rollout-id-123"
created = client.post(
Expand Down