fix(core): keep tool call pairs during token truncation - #8025
Open
林SO (Linxiushen) wants to merge 1 commit into
Open
fix(core): keep tool call pairs during token truncation#8025林SO (Linxiushen) wants to merge 1 commit into
林SO (Linxiushen) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Anuj Bolewar (anujbolewar)
left a comment
There was a problem hiding this comment.
Keeping an adjacent tool-call and its result together during truncation is the right call, since splitting the pair leaves a dangling result the model cannot interpret. The helper chooses a middle message and expands in either direction, which is reasonable. One edge: when the middle message is a tool call with no following result, or a result with no preceding call, it falls back to popping a single message — consider a comment spelling out that a lone message may legitimately be removed in those cases so it reads as intended rather than accidental.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
TokenLimitedChatCompletionContextremoves messages from the middle of the history one at a time. When the midpoint lands on either side of an assistant tool call and its execution result, this can leave an invalid history containing an orphaned result or call.This change treats adjacent assistant tool-call and execution-result messages as an indivisible pair during token truncation. It applies the same behavior to both explicit
token_limitcounting and model-clientremaining_tokenscounting.Regression coverage exercises both possible midpoint positions across both token-limit modes.
Related issue number
Closes #7955
Checks
Local checks:
pytest tests -q(230 passed)ruff format --check src testsruff check src testsmypy --config-file ../../pyproject.toml --exclude src/autogen_core/application/protos --exclude tests/protos src testspyright --pythonpath ../../.venv/Scripts/python.exe