Repository navigation
feat: [1/6] add core payload contracts and bounded processing - #388
Open
wangbill (YunchuWang) wants to merge 1 commit into
Open
wangbill (YunchuWang) wants to merge 1 commit into
wangbill (YunchuWang) wants to merge 1 commit into
Conversation
Phase 1 of 6: add provider-independent payload contracts, explicit protobuf mapping, UTF-8 size limits, bounded I/O and permanent worker upload failure conversion. Reserve the 0.4.1 core API version without enabling transport or cleanup yet. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Continue-as-new carryover payloads bypass externalization and configured size limits.
1 open finding
What changed in this PR
Adds the core foundation for optional external payload storage, ahead of transport and provider integration.
Changes:
- Introduces storage contracts and explicit protobuf payload mapping.
- Adds bounded processing, size checks, failure conversion, and regression tests.
- Reserves core version
0.4.1and synchronizes dependency metadata.
| File | Description |
|---|---|
| packages/durabletask-js/test/payloads.spec.ts | Tests mapping, limits, failures, and concurrency. |
| packages/durabletask-js/src/payloads/run-bounded.ts | Bounds concurrency and drains started operations. |
| packages/durabletask-js/src/payloads/payload-store.ts | Defines storage contracts, options, and errors. |
| packages/durabletask-js/src/payloads/payload-processor.ts | Maps and processes protobuf payload fields. |
| packages/durabletask-js/src/index.ts | Exports payload contracts. |
| packages/durabletask-js/package.json | Reserves core 0.4.1. |
| packages/azure-functions-durable/package.json | Updates the exact core dependency. |
| package-lock.json | Synchronizes version metadata. |
| CHANGELOG.md | Documents the foundation and phased release. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| action.getSendentitymessage()?.getEntityoperationsignaled()?.getInput(), | ||
| action.getSendentitymessage()?.getEntityoperationcalled()?.getInput(), | ||
| ); | ||
| for (const event of action.getRewindorchestration()?.getNewhistoryList() ?? []) { |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
Why is this change needed?
91739687. The complete stack preserves the original implementation atc9b53fcb3ab8585c4b3b22f9c0500cc9dd122c5a, with the documented instance-kind routing correction.Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
These human attestations are intentionally left unchecked.
Testing
Automated tests
npm ci --offline --no-audit --no-fund— passed.npm run build— passed all four existing workspaces on this snapshot.npm run lint— passed.npm run test:unit -w @microsoft/durabletask-js— passed 1,811 tests in 90 suites.prettier --checkon the changed TS/JSON files — passed.git diff --check origin/main...HEAD— passed.Manual validation (only if runtime/behavior changed)
Notes for reviewers
mainyunchuwang-payload-phase-1-coreyunchuwang-payload-phase-2-sdkyunchuwang-payload-phase-3-blobyunchuwang-payload-phase-4-clientyunchuwang-payload-phase-5-workerMerge 1 → 2 → 3 → 4 → 5 → 6. Each PR targets its predecessor; retarget the next PR only after its prerequisite merges. Do not publish packages or describe a partial phase as the complete feature.