Skip to content

feat: support bulk-export command#261

Open
ohadedry wants to merge 11 commits into
microsoft:mainfrom
ohadedry:support-bulk-export-command
Open

feat: support bulk-export command#261
ohadedry wants to merge 11 commits into
microsoft:mainfrom
ohadedry:support-bulk-export-command

Conversation

@ohadedry

@ohadedry ohadedry commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✨ Description of new changes

This pull request introduces a new bulk-export command to the CLI, enabling bulk export of all supported items from a workspace or folder while preserving folder structure and item bindings. The implementation includes API integration, argument validation, error handling, and comprehensive documentation and examples. The changes also update command support configuration and the command index.

New Functionality:

  • Added a new bulk-export command that allows users to export all supported items from a workspace or folder in a single operation, preserving folder structure and item bindings. This includes both CLI logic and integration with the backend API. [1] [2] [3] [4] [5]

Documentation Updates:

  • Added a new documentation page bulk_export.md detailing usage, parameters, supported item types, output structure, and examples for the bulk-export command.
  • Updated the command index and navigation to include bulk-export. [1] [2]
  • Added example usage sections for bulk-exporting workspaces and folders in the relevant examples files. [1] [2]

Command Support and Configuration:

  • Registered the new bulkexport command in the CLI command enumeration and in the command support YAML, specifying supported elements (workspace, folder) and item types. [1] [2]

Internal Integration and Validation:

  • Integrated the bulk-export command into the main command handler and ensured argument validation, context checking, and user confirmation logic are in place. [1] [2] [3]
  • Improved error handling and user prompts for export preconditions, including checks for recursive export and non-empty output folders.

Minor Improvements:

  • Updated logging in the API client to include command context for improved traceability.
  • Added copyright headers to new files.

These changes collectively introduce and document the new bulk-export feature, making it easier for users to export entire workspaces or folders with structure and bindings preserved.# 📥 Pull Request

Copilot AI review requested due to automatic review settings July 6, 2026 10:51
@ohadedry
ohadedry requested a review from a team as a code owner July 6, 2026 10:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new bulk-export command to Fabric CLI (fab) to export all supported items from a workspace or folder in one operation, preserving folder structure and item bindings. It includes end-to-end command wiring (parser → command handler → API client), export utilities for writing bulk-export definition parts to storage, debug-log redaction improvements, and corresponding documentation + tests (including VCR recordings).

Changes:

  • Implemented bulk-export command flow (parsing, command dispatch, workspace/folder execution paths, API call, and export-to-storage utilities).
  • Extended export utilities and HTTP debug logging to better support bulk export payload shapes and reduce noisy/large debug logs.
  • Added docs pages/examples and comprehensive tests + recordings for the new command.

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tests/test_utils/test_fab_cmd_bulk_export_utils.py Unit tests for bulk-export utility helpers (payload creation, summary output, path stripping/export).
tests/test_core/test_fab_logger.py Updates logger tests for new command-context-aware response logging/redaction.
tests/test_commands/test_bulk_export.py New command-level tests for bulk-export behavior and output structure.
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_workspace_without_recursive_fail.yaml VCR recording for workspace bulk-export missing --recursive.
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_workspace_folder_without_recursive_fail.yaml VCR recording for folder bulk-export missing --recursive.
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_output_path_not_empty_warning.yaml VCR recording for warning behavior when output directory is non-empty.
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_no_exportable_items_fail.yaml VCR recording for “no exportable items” failure case.
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_item_fail.yaml VCR recording for invalid target type (item path).
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_empty_workspace_fail.yaml VCR recording for empty workspace failure case.
tests/test_commands/recordings/test_commands/test_bulk_export/test_bulk_export_empty_folder_fail.yaml VCR recording for empty folder failure case.
tests/test_commands/recordings/test_commands/test_bulk_export/class_setup.yaml VCR class setup recording for bulk-export command tests.
tests/test_commands/commands_parser.py Registers the new bulk-export parser into the command test harness.
src/fabric_cli/utils/fab_commands.py Adds bulk-export to the CLI command index text.
src/fabric_cli/utils/fab_cmd_export_utils.py Extends decode/export helpers to support definitionParts payload shape.
src/fabric_cli/utils/fab_cmd_bulk_export_utils.py New bulk-export utility module (payload, export writing, summary printing, path validation).
src/fabric_cli/parsers/fab_fs_parser.py Adds argparse registration for the bulk-export command.
src/fabric_cli/errors/bulk_export.py Defines bulk-export-specific error messages.
src/fabric_cli/core/fab_parser_setup.py Wires bulk-export parser into the global CLI parser setup.
src/fabric_cli/core/fab_logger.py Adds command context to response logging + JSON response redaction logic.
src/fabric_cli/core/fab_constant.py Adds COMMAND_FS_BULKEXPORT_DESCRIPTION.
src/fabric_cli/core/fab_config/command_support.yaml Registers bulk-export support matrix (workspace/folder + supported item types).
src/fabric_cli/core/fab_commands.py Adds FS_BULKEXPORT command enum value.
src/fabric_cli/commands/fs/fab_fs.py Hooks bulk_export_command into the fs command module.
src/fabric_cli/commands/fs/fab_fs_bulk_export.py New bulk-export command implementation and precondition checks.
src/fabric_cli/commands/fs/bulk_export/fab_fs_bulk_export_workspace.py Workspace bulk-export execution and response filtering.
src/fabric_cli/commands/fs/bulk_export/fab_fs_bulk_export_folder.py Folder bulk-export execution and recursive item collection.
src/fabric_cli/commands/fs/bulk_export/init.py Package init for bulk-export submodule.
src/fabric_cli/client/fab_api_item.py Adds bulk_export_definitions() API wrapper.
src/fabric_cli/client/fab_api_client.py Passes command context into HTTP response debug logging.
mkdocs.yml Adds bulk-export page to MkDocs navigation.
docs/examples/workspace_examples.md Adds workspace bulk-export example section.
docs/examples/folder_examples.md Adds folder bulk-export example section.
docs/commands/index.md Adds bulk-export to the command index page.
docs/commands/fs/bulk_export.md New bulk-export command documentation page.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py Outdated
Comment thread src/fabric_cli/parsers/fab_fs_parser.py Outdated
Comment thread src/fabric_cli/parsers/fab_fs_parser.py Outdated
Comment thread src/fabric_cli/utils/fab_commands.py
Comment thread src/fabric_cli/core/fab_constant.py
Comment thread docs/commands/fs/bulk_export.md
Comment thread tests/test_commands/test_bulk_export.py
Comment thread docs/commands/fs/bulk_export.md
Comment thread docs/commands/fs/bulk_export.md
Comment thread docs/commands/fs/bulk_export.md
Comment thread docs/commands/fs/bulk_export.md Outdated
Comment thread docs/commands/fs/bulk_export.md
Comment thread docs/commands/index.md Outdated
Comment thread docs/examples/folder_examples.md Outdated
Comment thread src/fabric_cli/client/fab_api_item.py Outdated
Comment thread src/fabric_cli/parsers/fab_fs_parser.py
Comment thread src/fabric_cli/utils/fab_cmd_export_utils.py Outdated
Comment thread src/fabric_cli/utils/fab_commands.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 10:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 7 comments.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py Outdated
Comment thread docs/commands/fs/bulk_export.md
Comment thread tests/test_commands/test_bulk_export.py Outdated
Comment thread tests/test_commands/test_bulk_export.py
Comment thread tests/test_commands/test_bulk_export.py Outdated
Comment thread tests/test_commands/test_bulk_export.py
Comment thread tests/test_commands/test_bulk_export.py
Copilot AI review requested due to automatic review settings July 8, 2026 12:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 6 comments.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
Comment thread tests/test_core/test_fab_logger.py
Comment thread docs/commands/fs/bulk_export.md
Copilot AI review requested due to automatic review settings July 8, 2026 12:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/fabric_cli/utils/fab_cmd_export_utils.py:63

  • The docstring still says this function exports from the 'parts' array, but the implementation now supports an arbitrary key via definition_parts (e.g., definitionParts for bulk-export). Updating the docstring avoids misleading future callers.
    """
    Export each 'payload' in the 'parts' array to a file named based on 'path' in 'parts'.
    The 'payload' content will be saved as the file's content.
    """

Comment thread tests/test_commands/commands_parser.py
Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py Outdated
Copilot AI review requested due to automatic review settings July 12, 2026 11:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Copilot AI review requested due to automatic review settings July 12, 2026 11:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 4 comments.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread src/fabric_cli/utils/fab_cmd_export_utils.py
Comment thread tests/test_core/test_fab_logger.py
Copilot AI review requested due to automatic review settings July 14, 2026 10:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 7 comments.

Comment thread docs/commands/fs/bulk_export.md
Comment thread tests/test_core/test_fab_logger.py
Comment thread tests/test_core/test_fab_logger.py
Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread tests/test_core/test_fab_logger.py
Comment thread tests/test_core/test_fab_logger.py
Copilot AI review requested due to automatic review settings July 14, 2026 11:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/fabric_cli/utils/fab_cmd_export_utils.py:63

  • export_json_parts now supports exporting from different list keys via the definition_parts parameter, but the docstring still describes only the 'parts' array. Updating it to reflect the new parameter will prevent confusion for future callers and maintainers.
def export_json_parts(
    args, definition: dict, export_path: dict, definition_parts="parts"
) -> None:
    """
    Export each 'payload' in the 'parts' array to a file named based on 'path' in 'parts'.
    The 'payload' content will be saved as the file's content.
    """

Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py
Comment thread docs/examples/folder_examples.md
Comment thread docs/examples/folder_examples.md
Comment thread docs/examples/folder_examples.md
Comment thread src/fabric_cli/client/fab_api_client.py
Comment thread src/fabric_cli/commands/fs/bulk_export/fab_fs_bulk_export_folder.py
Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread src/fabric_cli/parsers/fab_fs_parser.py
Comment thread src/fabric_cli/parsers/fab_fs_parser.py Outdated
Comment thread src/fabric_cli/parsers/fab_fs_parser.py
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py
Comment thread src/fabric_cli/utils/fab_cmd_export_utils.py Outdated
Comment thread src/fabric_cli/utils/fab_cmd_export_utils.py
Comment thread src/fabric_cli/parsers/fab_fs_parser.py Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 14:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 4 comments.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread src/fabric_cli/utils/fab_cmd_export_utils.py
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py
Comment thread src/fabric_cli/core/fab_constant.py
Comment thread src/fabric_cli/parsers/fab_fs_parser.py
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py Outdated
ayeshurun
ayeshurun previously approved these changes Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 13:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 5 comments.

Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py
Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py
Comment thread src/fabric_cli/commands/fs/fab_fs_bulk_export.py Outdated
Comment thread src/fabric_cli/commands/fs/bulk_export/fab_fs_bulk_export_folder.py
Copilot AI review requested due to automatic review settings July 19, 2026 11:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/fabric_cli/commands/fs/fab_fs_bulk_export.py:61

  • The output directory validation rejects non-existent local paths (not os.path.isdir(...)), which prevents creating a new output folder even though the code later calls os.makedirs(...). This makes bulk-export -o <new-dir> fail unnecessarily.
    export_path = fab_storage.get_export_path(args.output)
    if (export_path["type"] != "local") or (
        export_path["type"] == "local" and not os.path.isdir(export_path["path"])
    ):
        raise FabricCLIError(

Comment thread src/fabric_cli/utils/fab_cmd_bulk_export_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants