Repository navigation
release: fix Mac builds for missing Rust - #1000
Merged
Merged
Conversation
Matthew John Cheetham (mjcheetham)
requested a review
from Johannes Schindelin (dscho)
October 8, 2026 14:50
The new ACES macOS image does not include Rust or rustup, so release builds can no longer rely on the previous image's preinstalled tools. Native Homebrew Rust supplies Cargo and the host standard library, making rustup target installation unnecessary. An explicit Rust target keeps the static archive aligned with the C objects, while checking for its libraries provides a clear failure before starting the build. Keep the host, C and Rust architecture names together in the macOS matrix so compilation, packaging and validation stay aligned. The existing ARM64-only output is unchanged. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Matthew John Cheetham (mjcheetham)
force-pushed
the
rust-macfix
branch
from
October 8, 2026 14:52
ee9838a to
de069d1
Compare
The Mac builds make temporary commits when building. In previous macOS images we had the user.name and user.email already set. Set the commit author variables for our build so these temporary commits continue to work. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Member
Author
|
Example build (Microsoft engineers only) |
Johannes Schindelin (dscho)
approved these changes
Oct 8, 2026
Johannes Schindelin (dscho)
left a comment
Johannes Schindelin (dscho)
left a comment
Member
There was a problem hiding this comment.
Nice! And good job grabbing the PR number "one thousand" 😉
Matthew John Cheetham (mjcheetham)
merged commit Oct 9, 2026
3343cd4
into
vfs-2.56.0
158 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On our new Mac image from the AcesShared agent pool, the Rust toolchain is not preinstalled.
Install Rust via Homebrew, like we do for the rest of our dependencies.
Since Rust in Homebrew does not include
rustup, we cannot use that command to ensure our triple is installed. However, Homebrew will install the triple for the native host, which for us is:Let's fix our build job steps on Mac to work like the Windows and Linux jobs - correctly define the architecture parameters we care about and use those consistently.
Also, the old image used to already have a Git commit author set whereas the new image does not. The build makes temporary commits which fails if this is not set - let's set them to some sensible value.