Repository navigation
release: speed up PME approval for release builds - #999
Merged
Merged
Conversation
Due to the multi-staged setup of our release builds, when we are doing ESRP signing we only get prompted to approve via a PME account when we reach the second stage of the pipeline (build+sign). There is often a long delay to this because stage one agent provisioning can take a long time, meaning the person queuing the pipeline must wait around until the PME approval is triggered at the start of stage two. Once approval has been granted for any stage of the pipeline, the rest can use the same approval. Let's add an arbitrary task to the first stage that would trigger the PME approval - anything that uses the ESRP service connection - so the person queuing the pipeline can work on the approval right away, rather than wait for the second stage to start. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Matthew John Cheetham (mjcheetham)
requested a review
from Johannes Schindelin (dscho)
October 8, 2026 12:21
Johannes Schindelin (dscho)
approved these changes
Oct 8, 2026
Johannes Schindelin (dscho)
left a comment
Johannes Schindelin (dscho)
left a comment
Member
There was a problem hiding this comment.
Thank you so much!
Matthew John Cheetham (mjcheetham)
merged commit Oct 8, 2026
93c5b6e
into
vfs-2.56.0
151 of 153 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the multi-staged setup of our release builds, when we are doing ESRP signing we only get prompted to approve via a PME account when we reach the second stage of the pipeline (build+sign). There is often a long delay to this because stage one agent provisioning can take a long time, meaning the person queuing the pipeline must wait around until the PME approval is triggered at the start of stage two.
Once approval has been granted for any stage of the pipeline, the rest can use the same approval.
Let's add an arbitrary task to the first stage that would trigger the PME approval - anything that uses the ESRP service connection - so the person queuing the pipeline can work on the approval right away, rather than wait for the second stage to start.