Repository navigation
[release-branch.go1.26] Skip doc reproducibility test if document is a copy - #2673
Merged
Davis Goodin (dagood) merged 1 commit intoOct 28, 2026
Conversation
Davis Goodin (dagood)
commented
Oct 28, 2026
Davis Goodin (dagood)
commented
Member
- Port Skip doc reproducibility test if document is a copy #2672
(cherry picked from commit c1f0665)
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to recognize automatically copied crypto documentation and skip local regeneration checks.
No open issues 🎉
What changed in this PR
Ports #2672 to release-branch.go1.26, preventing documentation syncs from failing the crypto documentation reproducibility test when the document is maintained by automatic copying.
Changes:
- Adds a shared helper to recognize the copy notice with either LF or CRLF line endings.
- Tests copied documents and nonmatching prefixes.
- Skips local regeneration checks for automatically copied crypto documentation.
| File | Description |
|---|---|
eng/_util/internal/docutil/docutil.go |
Detects the automatic documentation copy notice. |
eng/_util/internal/docutil/docutil_test.go |
Tests copy detection, line endings, and prefix edge cases. |
eng/_util/cmd/updatecryptodocs/updatecryptodocs_test.go |
Skips the reproducibility test for copied documents. |
Review effort: Balanced
Quim Muntal (qmuntal)
approved these changes
Oct 28, 2026
Davis Goodin (dagood)
enabled auto-merge (squash)
October 28, 2026 22:01
Davis Goodin (dagood)
merged commit Oct 28, 2026
7c65ca5
into
microsoft/release-branch.go1.26
48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.