Repository navigation
Revise PIE and immediate binding docs - #2679
Merged
Davis Goodin (dagood) merged 3 commits intoOct 30, 2026
Merged
Conversation
Davis Goodin (dagood)
requested review from
Quim Muntal (qmuntal)
and
a balanced review from Copilot
October 30, 2026 17:55
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documented command omits the no-crypto qualification, incorrectly implying fully static support for programs whose cgo-less OpenSSL backend still requires shared libraries and a dynamic loader.
1 open issue
What changed in this PR
This documentation-only PR clarifies the Linux PIE and ELF immediate-binding defaults introduced for Go 1.28.
Changes:
- Simplifies the migration guide entries and links to detailed feature documentation.
- Clarifies PIE architecture coverage, sanitizer exceptions, and dynamic-loader requirements.
- Expands the explanation of immediate binding and its relationship to RELRO protection.
| File | Description |
|---|---|
eng/doc/MigrationGuide.md |
Shortens the summaries of the new linker defaults. |
eng/doc/AdditionalFeatures.md |
Explains PIE compatibility and runtime requirements, plus ELF binding and RELRO behavior. |
Review effort: Balanced
George Adams (gdams)
approved these changes
Oct 30, 2026
Quim Muntal (qmuntal)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify, simplify, with some investigative work by Copilot.