[NFC] Remove duplication across allocate jit memory windows for x64 and arm64 - #129
Merged
Jingyu Ma (mazong1123) merged 1 commit intoMar 30, 2026
Conversation
Luciano Almeida (lucianopa-msft)
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refactors Windows JIT memory allocation to remove duplicated logic between x86_64 and aarch64 by sharing the same search/allocate loop and only varying max_range.
Changes:
- Consolidates the Windows
allocate_jit_memory_windowsimplementation for x86_64 and aarch64 into a single code path. - Replaces per-architecture duplicated loops with architecture-specific
max_rangedefinitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Luciano Almeida (lucianopa-msft)
force-pushed
the
lucianopa/nfc-clean-up
branch
from
March 30, 2026 17:28
f1578c8 to
8a485a6
Compare
Luciano Almeida (lucianopa-msft)
force-pushed
the
lucianopa/nfc-clean-up
branch
from
March 30, 2026 17:28
8a485a6 to
834d643
Compare
Copilot started reviewing on behalf of
Luciano Almeida (lucianopa-msft)
March 30, 2026 17:50
View session
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jingyu Ma (mazong1123)
merged commit Mar 30, 2026
95a9d8a
into
microsoft:main
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just reduce duplication for consistency since only thing that differs now is the max_range.
So just a non-functional change that reduces code duplication.